| Summary: | AVM FRITZ!Card DSL Series ebuild for kernel 2.6 series (incl. new capi4k-utils) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | tuXXer <bs.net> |
| Component: | New packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo_bugs.gebhardt, mog.johnny, net-dialup, schleinzer, skeimer, submuffi, tove |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
capi4k-utils version 20040331
fcdsl version 2.6 fcdsl-2.6 v 2.0 with peers script fcdsl-2.6.tar.bz2 (for the testers) net-dialup/capi4k-utils/capi4k-utils-20040331.ebuild net-dialup/capi4k-utils/files/capi net-dialup/fcdsl/files/capi.conf net-dialup/fcdsl/files/fcdsl net-dialup/fcdsl/files/pap-secrets net-dialup/fcdsl/files/peer net-dialup/fcdsl/fcdsl-2.6.ebuild Adopted ebuild net-dialup/fcdsl/fcdsl-2.6.ebuild net-dialup/fcdsl-2.6.20.7.ebuild net-dialup/fcdsl-2.6.20.7-r1.ebuild |
||
|
Description
tuXXer
2004-05-11 01:23:26 UTC
Created attachment 31196 [details]
capi4k-utils version 20040331
Adding ebuild for capi4k-utils version 20040331 (needed for fcdsl-2.6)
Created attachment 31197 [details]
fcdsl version 2.6
AVM driver ebuild for kernel version 2.6
Supported cards:
- AVM FRITZ!Card DSL
- AVM FRITZ!Card DSL SL
- AVM FRITZ!Card DSL v2.0
- AVM FRITZ!Card DSL USB
- AVM FRITZ!Card DSL SL USB
Comment on attachment 31197 [details]
fcdsl version 2.6
Adding new version with creating connection script in /etc/ppp/peers and
editing pap-secrets
Created attachment 31296 [details]
fcdsl-2.6 v 2.0 with peers script
New ebuild with editing pap-secrets and creating peers file
Well, I'm working on the variable handling, inputs and card definitions to make they more readable and better. Then I update the ebuild and split the files according to the ebuild guidlines. Created attachment 31353 [details]
fcdsl-2.6.tar.bz2 (for the testers)
Just the final ebuild, with better variables declarations and better handling.
Much faster installation...
Only for direct install for testers.
The files following...
Created attachment 31354 [details]
net-dialup/capi4k-utils/capi4k-utils-20040331.ebuild
The capi4k-utils Ebuild Version from 2004-03-31
Created attachment 31355 [details]
net-dialup/capi4k-utils/files/capi
init.d file for capi4k-utils
Created attachment 31356 [details]
net-dialup/fcdsl/files/capi.conf
Firmware/module configuration for AVM FRITZ!Card DSL
Created attachment 31357 [details]
net-dialup/fcdsl/files/fcdsl
Module options for modules.d
Created attachment 31358 [details]
net-dialup/fcdsl/files/pap-secrets
PAP-Secrets file
Created attachment 31359 [details]
net-dialup/fcdsl/files/peer
Peer file for ppp/peers
Created attachment 31360 [details]
net-dialup/fcdsl/fcdsl-2.6.ebuild
The AVM FRITZ!Card DSL ebuild
Created attachment 38978 [details]
Adopted ebuild
Adding nomirror and new rpm file from SuSE and copying pap-secrets instead of
add new one
capi4k-utils-20040810 I'll look at fdcs sometime. Sounds great! Well, then I should check the newest one in ;-) Created attachment 40498 [details]
net-dialup/fcdsl/fcdsl-2.6.ebuild
New ebuild with changing to rpm-eclass
Wow - looks fair complicated - hope it works cause I can't test it.
Can I get you to fix the following things before I include this:
1. Copyright header - should be /usr/portage/header.txt
2. I would of thought 20.7 was the version instead of 2.6
3. can you please test it against the latest version of net-dialup/capi4k-utils
4. So I can test it, and that it works for people doing binary compiles without the hardware - can the ebuild be modified to not fail if the hardware isn't detected. Is somehow placing comments/dummy values in the config file possible? I see this will mean compiling all of the kernel modules. Definately put an ewarn in to warn users that the hardware hasn't been detected.
5. Please try to avoid addwrite. Compiling kernels with O=${WORKDIR}/output is one way to compile into the staging directory. i.e:
mkdir ${WORKDIR}/output
sed -i -e "s: modules:O=${WORKDIR}/output modules:g" */src/Makefile
should work.
Also set KDIR=${KERNEL_DIR} (from kernel-mod eclass) before the compile for consistancy with other kernel-mod ebuilds.
6. Change insinto /lib/modules/ to /lib/modules/${KV_VERSION_FULL} after calling kernel-mod_getversion for consistant detection of kernel version.
7. ebuilds are not ment to be interactive. To save all the work you have done place the configuration part in a routine called "config". The user can then call ebuild /var/db/pkg/sys-kernel/${PF}/${PF}.ebuild config for the interactive configure. Make sure you call detect_fcdsl_card from within this routine.
8. Not that I distrust SuSE (was my distro before Gentoo) but I'd rather not put a RESTRICT="nomirror" in.
Please I do appreciate your efforts, and if you fix these few things, I will put the ebuild in. If you have any questions try to catch me on #gentoo-bugs or if you have any general ebuild questions you can ask there too.
Thankyou for your work so far.
*** Bug 40495 has been marked as a duplicate of this bug. *** *** Bug 43716 has been marked as a duplicate of this bug. *** *** Bug 46769 has been marked as a duplicate of this bug. *** *** Bug 47732 has been marked as a duplicate of this bug. *** *** Bug 55902 has been marked as a duplicate of this bug. *** *** Bug 49945 has been marked as a duplicate of this bug. *** bug 49945 contains patch for 2.4 kernel. Still applicable? Please don't mix the ISDN cards with DSL cards! A little to many bugs marked as duplicate in my opinion. As tove mentioned don't mix DSL and ISDN drivers. Bugs 55902 and 46769 deal with FritzCard ISDN drivers on 2.6 Kernels so there could be two duplicates. Bug 49945 is about compiling fcpci-03.11.02 on 2.4.26 so I doubt it duplicates DSL on 2.6 in any way ... Daniel Sorry for mixing the ISDN cards with DSL cards. Is fcpci the same code as this one? Is it possible to make one ebuild that does both. If so I'd rather maintain one even if it does have a few 2.4/2.6 branches in code. Mixing of fcpci with fcdsl, in my opinion, isn't good, because it is possible to use ADSL and ISDN cards together in one pc. The other thing is that the ADSL drivers from AVM aren't 100% equal to the ISDN drivers, as far as I know. How how about a virtual for this cards? ISDN and DSL will stay separate. fcpci will be fixed (if someone opens the right bug cause I think my bug editing priviledges need revoking). Sorry for the confusion. virtuals are to handles ebuild that depend on a number of possible which isn't the case here. Sorry for the confusion. I'm not going to try to say any more cause I'll say something wrong. again! Everyone sick of me spamming them yet? Bye for now 1. Copyright header - should be /usr/portage/header.txt
=> O.K.
2. I would of thought 20.7 was the version instead of 2.6
==> That's a good question, the fcdsl-2.6.20.7.src.rpm contains four different drivers. The indepent drivers (not all are available) have an other version string. 2.4 kernel drivers from AVM begin with e.g. 3. Would be 2.6.20.7 OK for you?
3. can you please test it against the latest version of net-dialup/capi4k-utils
=> I'm alway using the latest version. Well, I'm fixing the DEPS for it.
4. So I can test it, and that it works for people doing binary compiles without the hardware - can the ebuild be modified to not fail if the hardware isn't detected. Is somehow placing comments/dummy values in the config file possible? I see this will mean compiling all of the kernel modules. Definately put an ewarn in to warn users that the hardware hasn't been detected.
=> I think this is a bad idea, because the package includes 5 driver packages for 5 different cards. Which should I compile: one or all? Compiling all is much overflow for getting on card running. The other point is, that the kernel must be configure with capi. Is there a way to check this?
5. Please try to avoid addwrite. Compiling kernels with O=${WORKDIR}/output is one way to compile into the staging directory. i.e:
mkdir ${WORKDIR}/output
sed -i -e "s: modules:O=${WORKDIR}/output modules:g" */src/Makefile
should work.
Also set KDIR=${KERNEL_DIR} (from kernel-mod eclass) before the compile for consistancy with other kernel-mod ebuilds.
=> Nice idea, will try to fix it
6. Change insinto /lib/modules/ to /lib/modules/${KV_VERSION_FULL} after calling kernel-mod_getversion for consistant detection of kernel version.
=> O.K. so it should be...
7. ebuilds are not ment to be interactive. To save all the work you have done place the configuration part in a routine called "config". The user can then call ebuild /var/db/pkg/sys-kernel/${PF}/${PF}.ebuild config for the interactive configure. Make sure you call detect_fcdsl_card from within this routine.
=> Other ebuilds does this the same way (e.g. ut2004). But it is no problem to change this
8. Not that I distrust SuSE (was my distro before Gentoo) but I'd rather not put a RESTRICT="nomirror" in.
=> O.K. so it should be...
Sorry, for not using the IRC net but I'm at work...
>ISDN and DSL will stay separate. fcpci will be fixed (if someone opens the right bug cause I think my bug editing priviledges need revoking). Sorry for the confusion. virtuals are to handles ebuild that depend on a number of possible which isn't the case here. Sorry for the confusion. I'm not going to try to say > any more cause I'll say something wrong. again! > > Everyone sick of me spamming them yet? Bye for now No, problem! I think the spamming were worth it, because after a long time of non development in net-dialup, someone does the work. And nobody is perfect! ;-) 2.
2.6.20.7 is good
4.
Was thinking all. It is only the case if non were detected. I'm assuming the modules names don't confict.
capi testing - fgrep ${KERNEL_DIR}/.config. I'd only do this to issue a warning that a recompile is needed.
Created attachment 40567 [details]
net-dialup/fcdsl-2.6.20.7.ebuild
Well, following changes made
a) Use of kmod-eclass instead of kernel-mod
b) Creating pkg_config section for peer file creation
c) Detection doesn't stop compile, when no card detected all sources are build
d) Detection of CONFIG_ISDN_CAPI_CAPI20 added (kmod_get_config_var)
e) Using KV_VERSION_FULL
f) Using kmod_src_compile
g) Dynamical write of all configuration files
h) adding sys-kernel/config-kernel to DEPS, because of kmod_src_compile, to
remove addwrite
Hope, I didn't miss something ;-)
good enough :-) added thankyou and well done. BTW seems to be problems setting config-kernel to stuff other than addwrite. I'm sure thats a config-kernel problem though. Created attachment 44363 [details]
net-dialup/fcdsl-2.6.20.7-r1.ebuild
Changing from kmod to kernel-mod because kmod is obsolete
|
