Summary: | src_compile could be more generic | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Mr. Bones. (RETIRED) <mr_bones_> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | agriffis |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 51933 | ||
Bug Blocks: |
Description
Mr. Bones. (RETIRED)
![]() This would be best: if [ -x ./configure ]; then econf || die "econf failed" fi if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then emake || die "emake failed" fi Thanks Aron. That would be ideal portage devs. ^^^^ This breaks with packages that have a Makefile that's only used for `make install` (e.g. sys-apps/man-pages) sys-apps/man-pages should just supply an empty src_compile function I think. That is a pretty unusual case. The more general case (that is, probably autoconf, followed in frequency by simple makefiles that are used for compiling and installing) should be the one supported by the generic src_compile in my opinion. FWIW, I agree with Mr_Bones_, man-pages should just supply an "empty" function: src_compile() { true # nothing to do, override default src_compile } This is in _pre9, and I changed man-pages so that it doesn't explode. |