| Summary: | net-misc/tigervnc: init script: make POSIX compliant (currently uses ${!var} and arrays) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mgorny |
| Priority: | Normal | Keywords: | NeedPatch, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/24703 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 609070 | ||
|
Description
Patrick Lauer
2014-04-02 09:10:26 UTC
we do not track "compatible with XXX shell", we track "is it POSIX compliant"
in this case, it is not:
usrname=${user%%:*}
usropts=VNC_OPTS_${usrname}
usrdisp=${user##*:}
usrvar=$usropts"["$usrdisp"]"
[ -z ${!usrvar} ] && vnc_opts=$VNC_OPTS || vnc_opts=${!usrvar}
rather than use VNC_OPTS_user[disp], we could use VNC_OPTS_user_disp and `eval` to get the value
This makes it impossible to use this on FreeBSD. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f94f6f15314c9a4b161efacb57042744346bc234 commit f94f6f15314c9a4b161efacb57042744346bc234 Author: Viorel Munteanu <ceamac.paragon@gmail.com> AuthorDate: 2022-03-22 07:27:03 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-03-22 18:01:11 +0000 net-misc/tigervnc: Fix the init script Remove $VNC_OPTS from conf.d Make init script POSIX compliant Closes: https://bugs.gentoo.org/835730 Closes: https://bugs.gentoo.org/506522 Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/24703 Signed-off-by: Sam James <sam@gentoo.org> net-misc/tigervnc/files/tigervnc-1.12.0.confd | 4 ++-- net-misc/tigervnc/files/tigervnc-1.12.0.initd | 28 ++++++++++------------ ...-1.12.0-r2.ebuild => tigervnc-1.12.0-r3.ebuild} | 0 3 files changed, 14 insertions(+), 18 deletions(-) |
