Summary: | app-portage/emerge-delta-webrsync-3.7.2: fails to make updated archive tarball unless tarsync is installed | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Ameretat.Reith |
Component: | Core - External Interaction | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS, PATCH, REGRESSION |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
remove unnecessary portage-XXX.tar removal
emerge-delta-webrsync: fix bug #506192 |
Description
Ameretat.Reith
2014-03-29 20:48:05 UTC
Created attachment 373850 [details, diff]
remove unnecessary portage-XXX.tar removal
(In reply to Ameretat.Reith from comment #1) > Created attachment 373850 [details, diff] [details, diff] > remove unnecessary portage-XXX.tar removal The intention is really to clean up "${TMPDIR}"/portage there, because it's a temporary copy of the *whole* portage tree, and it's no longer needed after that point. (In reply to Zac Medico from comment #2) > (In reply to Ameretat.Reith from comment #1) > > Created attachment 373850 [details, diff] [details, diff] [details, diff] > > remove unnecessary portage-XXX.tar removal > > The intention is really to clean up "${TMPDIR}"/portage there, because it's > a temporary copy of the *whole* portage tree, and it's no longer needed > after that point. End of script contains a section to remove "${TMPDIR}" again. Seems to me removing "${TMPDIR}" conditionally is just needed before exiting with codes 5 or 7, but currently I have not a handy environment to test it. (In reply to Ameretat.Reith from comment #3) > (In reply to Zac Medico from comment #2) > > (In reply to Ameretat.Reith from comment #1) > > > Created attachment 373850 [details, diff] [details, diff] [details, diff] [details, diff] > > > remove unnecessary portage-XXX.tar removal > > > > The intention is really to clean up "${TMPDIR}"/portage there, because it's > > a temporary copy of the *whole* portage tree, and it's no longer needed > > after that point. > > End of script contains a section to remove "${TMPDIR}" again. Seems to me > removing "${TMPDIR}" conditionally is just needed before exiting with codes > 5 or 7, but currently I have not a handy environment to test it. Yeah, your patch is good, thanks. I've added emerge-delta-webrsync-3.7.2-r1 to the tree, and it uses sed to remove those 3 lines. I'll leave this bug open until your patch makes it into git. Created attachment 386250 [details, diff] emerge-delta-webrsync: fix bug #506192 This fixes the sync_local function so that it doesn't prematurely remove the whole TMPDIR when tarsync is not installed. In this case, we reallyonly want to remove the "${TMPDIR}"/portage directory which contains a temporary copy of the portage tree. The faulty code was introduced in commit 24f6a9599bcf445c468022264cd6952aad4d4076 when a bunch of code from emerge-webrsync was merged into emerge-delta-webrsync. |