| Summary: | x11-misc/synergy-1.4.17_p2055 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | José María Fernández González <josemariafg> |
| Component: | Current packages | Assignee: | Desktop Misc. Team <desktop-misc> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | tuxtor |
| Priority: | Normal | Keywords: | EBUILD, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
synergy-1.4.17_p2055.ebuild
synergy-1.4.17_p2055-cryptopp.patch Patch to disable tests based on gmock and gtest Patch for pthread flag (inherited from previous ebuilds) Patch to fix an ancient bug |
||
|
Description
José María Fernández González
2014-03-27 16:13:12 UTC
Created attachment 373640 [details]
synergy-1.4.17_p2055.ebuild
Created attachment 373642 [details, diff]
synergy-1.4.17_p2055-cryptopp.patch
Created attachment 373644 [details, diff]
Patch to disable tests based on gmock and gtest
Created attachment 373646 [details, diff]
Patch for pthread flag (inherited from previous ebuilds)
Created attachment 373648 [details, diff]
Patch to fix an ancient bug
The bug fixed by this patch is very ancient, and you realize about it after several days running synergy, as the usability degrades over time due an internal leak
(In reply to José María Fernández González from comment #5) The documented issue which is fixed by this patch http://synergy-foss.org/spit/issues/details/2935/ Comment on attachment 373640 [details]
synergy-1.4.17_p2055.ebuild
--- synergy-1.4.16_p1969.ebuild 2014-03-01 19:37:11.000000000 +0100
+++ - 2014-05-06 03:09:34.674699343 +0200
@@ -17,6 +17,9 @@
KEYWORDS="~alpha ~amd64 ~arm ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd ~x86-freebsd ~amd64-linux ~x86-linux ~x86-macos ~sparc-solaris ~x86-solaris"
IUSE="qt4"
+# These deps are not needed once we disable tests
+# >=dev-cpp/gmock-1.6.0
+# >=dev-cpp/gtest-1.6.0
COMMON_DEPEND="
>=dev-libs/crypto++-5.6.2
x11-libs/libICE
@@ -41,8 +44,10 @@
"
PATCHES=(
- "${FILESDIR}/${PN}-1.4.15-cryptopp.patch"
- "${FILESDIR}/${PN}-1.4.16_p1969-pthread.patch"
+ "${FILESDIR}/${PN}-${PVR}-cryptopp.patch"
+ "${FILESDIR}/${PN}-${PVR}-notest.patch"
+ "${FILESDIR}/${PN}-${PVR}-pthread.patch"
+ "${FILESDIR}/${PN}-${PVR}-nulljobbuildup.patch"
)
S=${WORKDIR}/${P/_p*/}-Source
Comment on attachment 373648 [details, diff]
Patch to fix an ancient bug
Please send that upstream.
Comment on attachment 373644 [details, diff]
Patch to disable tests based on gmock and gtest
Why would we want to disable tests?
Comment on attachment 373646 [details, diff]
Patch for pthread flag (inherited from previous ebuilds)
The old patch applies quite nicely.
(In reply to Jeroen Roovers from comment #8) > Comment on attachment 373648 [details, diff] [details, diff] > Patch to fix an ancient bug > > Please send that upstream. As you can read at the upstream bug report (link in comment #6), the bug and the patch are known by upstream since more than two years. Maybe synergy ebuild should use epatch_user, so this or another patches for bugs still not fixed upstream can be applied without modifying the ebuild. (In reply to Jeroen Roovers from comment #9) > Comment on attachment 373644 [details, diff] [details, diff] > Patch to disable tests based on gmock and gtest > > Why would we want to disable tests? I tried to create a patch in order to use gmock and gtest Gentoo libraries, instead of the included ones, with no success (In reply to José María Fernández González from comment #11) > Maybe synergy ebuild should use epatch_user, so this or another patches for > bugs still not fixed upstream can be applied without modifying the ebuild. It should have already. Since src_prepare() isn't defined, it might be doing it already since it relies on two eclasses which do define it. I have added that patch and made sure epatch_user gets run, without a revision bump. |
