Bug 504850 – gnome-base/libgnomeprint-2.18.8 fails because it is looking for freetype headers in /usr/include/freetype

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Harris Landgarten 2014-03-17 03:31:29 UTC]

gnome-base/libgnomeprint-2.18.8 fails to build with new freetype. freetype is installing header files in /usr/include/freetype2 and libgnomeprint is looking in /usr/include/freetype.

I worked around by ln -sf /usr/include/freetype2 /usr/include/freetype

after the ln libgnomeprint builds without issue

[Comment 1 Alexandre Rostovtsev (RETIRED) 2014-03-17 04:05:23 UTC]

Fixed without a revision bump, thanks for reporting.

+  17 Mar 2014; Alexandre Rostovtsev <[e-mail]>
+  libgnomeprint-2.18.8.ebuild,
+  +files/libgnomeprint-2.18.8-freetype-2.5.1.patch:
+  Fix building with >=freetype-2.5.1 (bug #504850, thanks to Harris
+  Landgarten).

[Comment 2 Fabio Rossi 2014-03-17 15:28:18 UTC]

the patch is not needed with freetype 2.4.11, which is the current stable version, because freetype's includes are installed in /usr/include/freetype2 (so the missing file is /usr/include/freetype2/freetype/ftoutln.h)

[Comment 3 Alexandre Rostovtsev (RETIRED) 2014-03-17 16:05:04 UTC]

(In reply to Fabio Rossi from comment #2)

But libgnomeprint-2.18.8 with the patch still builds with freetype-2.4.11, correct?

[Comment 4 Fabio Rossi 2014-03-17 19:11:21 UTC]

> But libgnomeprint-2.18.8 with the patch still builds with freetype-2.4.11,
> correct?

No, it fails, without the patch libgnomeprint-2.18.8 compiles correctly

[Comment 5 Pacho Ramos 2014-03-17 21:37:16 UTC]

I guess we can simply apply the patch on a revbump that would go to stable with newer freetype

[Comment 6 Alexandre Rostovtsev (RETIRED) 2014-03-17 21:41:44 UTC]

(In reply to Pacho Ramos from comment #5)
> I guess we can simply apply the patch on a revbump that would go to stable
> with newer freetype

I am 99% sure there is a way to patch gnomeprint so that it works with both versions of freetype. I thought that I got it right, but it seems I missed something. Rebuilding my stable chroot now to investigate...

[Comment 7 Pacho Ramos 2014-03-17 21:46:37 UTC]

Ah, ok, in that case no problem :) 

I was thinking that maybe it wouldn't deserve the effort as old freetype will likely be punted once the security fixed version is stabilized but, of course, making it compatible with both is much more elegant ;)

[Comment 8 Alexandre Rostovtsev (RETIRED) 2014-03-17 23:45:46 UTC]

+  17 Mar 2014; Alexandre Rostovtsev <[e-mail]>
+  libgnomeprint-2.18.8.ebuild, files/libgnomeprint-2.18.8-freetype-2.5.1.patch:
+  Fix patch to work with both freetype-2.4.11 and >=2.5.1 (bug #504850, thanks
+  to Fabio Rossi).

[Comment 9 Fabio Rossi 2014-03-18 00:02:55 UTC]

tested, thanks!

[Comment 10 Rafał Mużyło 2014-03-21 21:41:00 UTC]

(In reply to Alexandre Rostovtsev from comment #8)
> +  17 Mar 2014; Alexandre Rostovtsev <[e-mail]>
> +  libgnomeprint-2.18.8.ebuild,
> files/libgnomeprint-2.18.8-freetype-2.5.1.patch:
> +  Fix patch to work with both freetype-2.4.11 and >=2.5.1 (bug #504850,
> thanks
> +  to Fabio Rossi).

ahem,...

How about just

#include <ft2build.h>
#include FT_BBOX_H
#include FT_GLYPH_H
#include FT_OUTLINE_H

instead of that include path hackery ?

[Comment 11 Alexandre Rostovtsev (RETIRED) 2014-03-21 21:49:12 UTC]

(In reply to Rafał Mużyło from comment #10)
> ahem,...
> 
> How about just
> 
> #include <ft2build.h>
> #include FT_BBOX_H
> #include FT_GLYPH_H
> #include FT_OUTLINE_H
> 
> instead of that include path hackery ?

Because I can't read, thought it was FT_FTBBOX_H not FT_BBOX_H, and of course discovered that it wasn't working with 2.4.11 :)