Summary: | xfce-base/xfce4-session: add systemd/login1 hibernate/suspend support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | pelopor <majuterus> |
Component: | Current packages | Assignee: | XFCE Team <xfce> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | systemd |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugzilla.xfce.org/show_bug.cgi?id=9952 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=504046 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
diff -buw xfce4-session-4.10.1-r1.ebuild xfce4-session-4.10.1-r2.ebuild
patch to the xfce4-session sources patch to the xfce4-session sources to add systemd support for hibernate/suspend diff -buw xfce4-session-4.10.1-r1.ebuild xfce4-session-4.10.1-r2.ebuild systemd patch for 11.0 version patch for ebuild 11.0-r1 |
Description
pelopor
2014-03-10 07:19:31 UTC
Created attachment 372252 [details, diff]
diff -buw xfce4-session-4.10.1-r1.ebuild xfce4-session-4.10.1-r2.ebuild
Created attachment 372254 [details, diff]
patch to the xfce4-session sources
Taken from Archlinux.
Comment on attachment 372252 [details, diff] diff -buw xfce4-session-4.10.1-r1.ebuild xfce4-session-4.10.1-r2.ebuild Same problem as with bug 504046, should not use 'if use systemd' for patching, but fix configure.ac (or .ac.in?) and set EAUTORECONF=1 to trigger eautoreconf by xfconf.eclass To handle it from $(use_enable systemd) Needs a bug filed to http://bugzilla.xfce.org/ for review, I don't think it is this https://bugzilla.xfce.org/show_bug.cgi?id=10076 which is the only one I could find because it's already bug 469204 (In reply to pelopor from comment #2) > Created attachment 372254 [details, diff] [details, diff] > patch to the xfce4-session sources > > Taken from Archlinux. This patch looks good if I read it correctly, it just puts things behind already existing #ifdef SYSTEMD and $(use_enable systemd) So only upstream bug report missing, and this could be applied in tree Samuli, thankyou for your review and comment. I added the upstream bug report: https://bugzilla.xfce.org/show_bug.cgi?id=9952. And it turns out there is a newer patch, which applies to git. I modified that patch so as to applies v.4.10.1 source trees, i.e. so that the patch to configure.ac.in (git) apply configure.ac (v.4.10.1). As it involves configure.ac, I add "EAUTORECONF=1" to the ebuild, as well as delete "if use" in the $PATCHES. Created attachment 372368 [details, diff] patch to the xfce4-session sources to add systemd support for hibernate/suspend Patch taken from https://bugzilla.xfce.org/show_bug.cgi?id=9952, but a bit modified. Created attachment 372370 [details]
diff -buw xfce4-session-4.10.1-r1.ebuild xfce4-session-4.10.1-r2.ebuild
this is fixed by using upower-0.99 in xfce4-session-4.11+ which is now in ~arch (In reply to Samuli Suominen from comment #9) > this is fixed by using upower-0.99 in xfce4-session-4.11+ which is now in > ~arch Nope, I am using complete ~amd64 system (that includes xfce4-session-4.11.0-r1) and upower-0.99.0-r1 and with systemd, and I don't simply have the buttons suspend/hibernate. DIgging on the internet, I found it is because I don't have pm-utils installed, but with systemd I just don't want them. So I tried the patch for previous version, and it did not apply cleanly, so I applied by hand and created a new one for 4.11 which enables systemd suspend/hibernate back again. I tested, compiled and run it, and it just works (don't know if it may affect non systemd users), I will attach the patch and ebuild diff to review. Can someone reopen this bug BTW? P.S. I also noticed that the patch for 10.1 is not included in 11.0 version Created attachment 378566 [details, diff]
systemd patch for 11.0 version
Created attachment 378568 [details, diff]
patch for ebuild 11.0-r1
mmm... seems I disabled udisk USE in xfce4-power-manager, but still, it should work with systemd only (and that is the purpose of that patch) Disregard previous comment: udisks is not related to upower (my fault) I can confirm, that this bug is not fixed yet. I'm runnnig upower-0.99.0-r1 and xfce4-sesssion-4.11.0-r1. I don't fully understand: I guess that you are seeing that the patch currently applied in latest 4.10* is also needed in 4.11? |