Bug 50067 – php-sapi.eclass has bug in "check java config". it checks 1.4 ok, but fails with java 1.5

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Ricardo Lenz 2004-05-04 22:38:01 UTC]

php 4.3.6 has a bug in installation. it uses php-sapi.eclass, which has this bug:

on the moment it checks for java version >= 1.4, it doesnt consider java 1.5!
i changed the code and now it checks ok.

Reproducible: Always
Steps to Reproduce:
1. first, emerge java 1.5
2. then, emerge php 4.3.6
Actual Results:  
you get the error saying you dont have java version >= 1.4

Expected Results:  
check that i have java 1.5 and it is, indeed, >= 1.4   :)

i have done the following modification to the php-sapi.eclass file, around line 209:

if [ -n "${JDKVER/1.4.*}" -o -z "${JDKVER}" ]; then
	
		einfo "Checking for Java 1.5 .."

		if [ -n "${JDKVER/1.5.*}" -o -z "${JDKVER}" ]; then
			eerror "Please ensure that you have a JDK with a version of at least"
			eerror "1.4 selected using java-config"
			die
		fi
	fi

[Comment 1 Robin Johnson 2004-05-06 01:22:32 UTC]

does PHP even work correctly with Java1.5 ?
I mean function correctly, not just compile.

[Comment 2 Ricardo Lenz 2004-05-10 03:00:17 UTC]

well, right now i dont think it works with java 1.5... there are some other minor drawbacks with java 1.5 that may cause errors with php 4.3.6, but then it is a problem to be solved somewhere else (and with php 5 these problems might be gone).

the main problem here is that "checking for java version >= 1.4" doesnt check 1.5, which IS >= 1.4. so the message should be fixed to "checking for java version 1.4.x" or the following:

einfo "Checking for Java 1.5 .. (warning: 1.5 STILL BETA! use at your own risk!)"

i.e. putting a warning message around the line that checks for java version 1.5 right after the code the checks for java 1.4.

sorry for any errors i might have done in this message, i dont speak english very well :)

all in all, thanks!!! GENTOO ROCKS!!!

[Comment 3 Robin Johnson 2004-05-13 21:03:43 UTC]

fixed in cvs.