Summary: | media-libs/libsndfile-1.0.25-r1 fails with ld.gold - ../src/.libs/libsndfile.so: error: undefined reference to 'vorbis_synthesis_read' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Justin Lecher (RETIRED) <jlec> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | alex_y_xu, amigadave, drunkenbatman, esigra, kredba, nikoli, steffen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 269315, 372079 | ||
Attachments: |
build.log
select ld.bfd or fail early to keep away failures |
Description
Justin Lecher (RETIRED)
2014-01-27 14:34:35 UTC
Created attachment 368872 [details]
build.log
build.log
must be related to binutils version, cannot reproduce with 2.23.2 repro here on ~amd64, binutils 2.24-r2 and ld.gold works with ld.bfd hit this today too -- just updating the comment to help with searches Created attachment 389040 [details, diff]
select ld.bfd or fail early to keep away failures
Here's a workaround patch i stole from sys-boot/grub -- it selects ld.bfd if possible and dies during pkg_pretend if not possible. At least with this we won't keep getting broken emerges.
run into the same bug. A workaround was to add the "minimal" useflag Bug is still here .. any chance sound herd could OK my committing of this patch sometime in the next month? Sorry for the delay Ian, please go right ahead. I don't see any need to disable ld.gold, as in my opinion it is an issue with libsndfile not correctly defining needed libraries for the linker. The file ogg_vorbis.c is using all of the mentioned symbols, so libsndfile.so should be linked against -logg and -lvorbis. This trivial patch adds the required libraries to the linker command: --- a/src/Makefile.am.orig 2015-04-28 15:50:32.582535481 +0200 +++ b/src/Makefile.am 2015-04-28 15:50:58.972534537 +0200 @@ -50,7 +50,7 @@ libsndfile_la_SOURCES = $(FILESPECIFIC) $(noinst_HEADERS) nodist_libsndfile_la_SOURCES = $(nodist_include_HEADERS) libsndfile_la_LIBADD = libcommon.la GSM610/libgsm.la G72x/libg72x.la \ - @EXTERNAL_LIBS@ -lm + @EXTERNAL_LIBS@ -lm @OGG_LIBS@ @VORBIS_LIBS@ libcommon_la_SOURCES = $(COMMON) Afterwards libsndfile can be linked with ld.gold as it does with ld.bfd. @Ian #6: even though this is not a gold issue, there is now a better approach to disable the gold linker when needed: use tc-ld-disable-gold (see https://bugs.gentoo.org/show_bug.cgi?id=439082#c15 and https://bugs.gentoo.org/show_bug.cgi?id=470634#c30). But you should only do that for packages where ld.gold causes breakage of the linked binary/library or does not have the needed functionality (like the default-symver switch from sys-libs/db https://bugs.gentoo.org/show_bug.cgi?id=470634 or the VERSION stuff in dev-db/mariadb https://bugs.gentoo.org/show_bug.cgi?id=508724) (In reply to Steffen Hau from comment #10) > I don't see any need to disable ld.gold, as in my opinion it is an issue > with libsndfile not correctly defining needed libraries for the linker. The > file ogg_vorbis.c is using all of the mentioned symbols, so libsndfile.so > should be linked against -logg and -lvorbis. > > This trivial patch adds the required libraries to the linker command: > --- a/src/Makefile.am.orig 2015-04-28 15:50:32.582535481 +0200 > +++ b/src/Makefile.am 2015-04-28 15:50:58.972534537 +0200 > @@ -50,7 +50,7 @@ > libsndfile_la_SOURCES = $(FILESPECIFIC) $(noinst_HEADERS) > nodist_libsndfile_la_SOURCES = $(nodist_include_HEADERS) > libsndfile_la_LIBADD = libcommon.la GSM610/libgsm.la G72x/libg72x.la \ > - @EXTERNAL_LIBS@ -lm > + @EXTERNAL_LIBS@ -lm @OGG_LIBS@ @VORBIS_LIBS@ > > libcommon_la_SOURCES = $(COMMON) > > Afterwards libsndfile can be linked with ld.gold as it does with ld.bfd. > > @Ian #6: even though this is not a gold issue, there is now a better > approach to disable the gold linker when needed: use tc-ld-disable-gold (see > https://bugs.gentoo.org/show_bug.cgi?id=439082#c15 and > https://bugs.gentoo.org/show_bug.cgi?id=470634#c30). But you should only do > that for packages where ld.gold causes breakage of the linked binary/library > or does not have the needed functionality (like the default-symver switch > from sys-libs/db https://bugs.gentoo.org/show_bug.cgi?id=470634 or the > VERSION stuff in dev-db/mariadb > https://bugs.gentoo.org/show_bug.cgi?id=508724) still fails with gold linker with gcc 5.2 Can we please get a fix for the ebuild? thanks I just checked it again 1.0.25-r1 fails 1.0.26 works commit 6f4d6d4e5f9402581ccb90dcba045a509b03a99a Author: Justin Lecher <jlec@gentoo.org> Date: Tue Jan 26 09:51:14 2016 +0100 media-libs/libsndfile: Drop version vulnerable for CVE-2015-7805 Package-Manager: portage-2.2.27 Signed-off-by: Justin Lecher <jlec@gentoo.org> https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f4d6d4e5f9402581ccb90dcba045a509b03a99a |