Summary: | x11-libs/glamor-0.6.0[xv] - .../work/glamor-egl-0.6.0/src/glamor_xv.c:445:1: error: implicit declaration of function 'DamageDamageRegion' [-Werror=implicit-function-declaration] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Helmut Jarausch <jarausch> |
Component: | [OLD] Library | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander, esigra, nikoli |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=75466 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 416069 | ||
Bug Blocks: | 260867, 461954, 500368 | ||
Attachments: |
build log
glamor_xv.i (xz-compressed) 0001-glamor_xv-add-missing-include.patch |
Description
Helmut Jarausch
2014-01-27 11:08:18 UTC
Does it make a difference whether you set eselect opengl to xorg-x11 or ati? I have the same problem. The latest intel drivers require glamor 0.6.0 for USE=glamor. And I don't have any ati opengl drivers as I have an intel graphics chip. And does it still fail if you build glamor with the xv USE flag disabled? (In reply to Chí-Thanh Christopher Nguyễn from comment #3) > And does it still fail if you build glamor with the xv USE flag disabled? No, it builds just fine with USE=-xv here. Many thanks, Helmut I suspect that the issue is due to missing #include <xorg/damage.h> in glamor_xv.c but I have been unable to reproduce this issue so far. Could someone who sees this bug please add -save-temps to CFLAGS and attach /var/tmp/portage/x11-libs/glamor-0.6.0/work/glamor-egl-0.6.0/src/glamor_xv.i ? Created attachment 370128 [details]
glamor_xv.i (xz-compressed)
It doesn't build for me even with USE="gles -xv", but I run a stable system with just some packages keyworded, so I probably miss a dependency. I suspect it needs mesa-9.2, but keywording that seems to be a bit non-trivial. So I'll have to leave it as it is for now. Ok, I think I got it: # 1 "/usr/include/xorg/scrnintstr.h" 1 # 40 "/usr/include/xorg/xf86str.h" 2 # 1 "/usr/include/xorg/pixmapstr.h" 1 -# 54 "/usr/include/xorg/pixmapstr.h" +# 53 "/usr/include/xorg/pixmapstr.h" +# 1 "/usr/include/xorg/damage.h" 1 +# 30 "/usr/include/xorg/damage.h" looking at commit history of pixmapstr.h it seems that #include "damage.h" was added in http://cgit.freedesktop.org/xorg/xserver/commit/?id=9b8217f9ef6279fff6628631d18497bed0343ef9 So all xorg-server before 1.13 (which do not contain this commit) will fail with glamor[xv], and later versions work by accident due to inclusion of damage.h in pixmapstr.h. (In reply to Tamas Jantvik from comment #7) Then your bug is something else. Please open a new bug report and attach the relevant logs. (In reply to Chí-Thanh Christopher Nguyễn from comment #8) > So all xorg-server before 1.13 (which do not contain this commit) will fail > with glamor[xv], and later versions work by accident due to inclusion of > damage.h in pixmapstr.h. I have to stick to xorg-server-1.12.4-r2 since I need ati-drivers[legacy] The only ati-drivers[legacy] is 13.1_pre897 which blocks all versions of xorg-server higher than 1.12.49. So, what can I do to fix the issue (or does anybody know a more recent ati-drivers[legacy]) ? Thanks, Helmut Created attachment 370142 [details, diff]
0001-glamor_xv-add-missing-include.patch
Patch which should fix the problem, also sent upstream.
(In reply to Chí-Thanh Christopher Nguyễn from comment #10) > Created attachment 370142 [details, diff] [details, diff] > 0001-glamor_xv-add-missing-include.patch > > Patch which should fix the problem, also sent upstream. Thanks, works just fine! Helmut Fixed in 0.6.0 without a revbump. |