| Summary: | www-client/qupzilla - USE=kde fails to enable KWallet backend / add gnome-keyring backend support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Hongjiu Zhang <noctuorare> |
| Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nikoli |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=496908 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log | ||
|
Description
Hongjiu Zhang
2014-01-25 03:11:46 UTC
Ebuild has mistake, line: export KDE_INTEGRATION=$(use kde && echo false || echo true) should be: export KDE_INTEGRATION=$(use kde && echo true || echo false) or better: export KDE_INTEGRATION=$(usex kde 'true' '') *qupzilla-1.6.0-r1 (27 Jan 2014) 27 Jan 2014; Davide Pesavento <pesa@gentoo.org> +qupzilla-1.6.0-r1.ebuild, -qupzilla-1.6.0.ebuild: Fix kwallet integration, add support for gnome-keyring (bug 499182). Ebuild cleanup. Unfortunately, this is still not fixed. I just tried to build www-client/qupzilla-1.6.0-r1, and this doesn't build KWallet backend. I checked /var/tmp/portage/www-client/qupzilla-1.6.0-r1/work/qupzilla-1.6.0/src/plugins/plugins.pro, line 26-27: # KWalletPasswords only with KDE_INTEGRATION !contains(DEFINES, "KDE_INTEGRATION"): SUBDIRS -= $$PWD/KWalletPasswords Is there any special meanings about DEFINES? Is it checking environment variable KDE_INTEGRATION defined or just checking the content of DEFINES? Btw, where is Reopen status? is it removed? (In reply to Zhang Hongjiu from comment #3) > Is there any special meanings about DEFINES? Is it checking environment > variable KDE_INTEGRATION defined or just checking the content of DEFINES? > DEFINES is a qmake variable: http://qt-project.org/doc/qt-4.8/qmake-variable-reference.html#defines The env vars are read in src/defines.pri and DEFINES is augmented appropriately. (In reply to Davide Pesavento from comment #4) > (In reply to Zhang Hongjiu from comment #3) > > Is there any special meanings about DEFINES? Is it checking environment > > variable KDE_INTEGRATION defined or just checking the content of DEFINES? > > > > DEFINES is a qmake variable: > http://qt-project.org/doc/qt-4.8/qmake-variable-reference.html#defines > > The env vars are read in src/defines.pri and DEFINES is augmented > appropriately. Then it is a little wierd. Since even you set export in the ebuild, the build project still skipped the KWallet. I am trying to save a full build.log for my successful build. I used qlist to check the package content, which has no KWallet backend plugin files. Created attachment 369034 [details]
build.log
As you can see, the build log shows KDE_INTEGRATION at first. But after it starts to build plugins (except videoner plugin), it is no longer there.
I just tested with qupzilla-1.6.1. It works as the author claimed "fixed building new Gnome/KDE keyring passwords". Please close this bug if you think it is suitable to drop support for 1.6.0-r1 version. Thank you. |
