| Summary: | app-misc/task-2.3.0 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Renato Alves <simpledark> |
| Component: | Current packages | Assignee: | Tim Harder <radhermit> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hasufell, laen, mail, reivzy, skrattaren, svantoviit, whissi |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Ebuild changes between 2.2.0 and 2.3.0
rc directory changes for backwards compatibility with 2.2.0 Patch for task-2.3.0.ebuild Patch for task-2.3.0.ebuild Patch for addressing the rcdir issue from issue#1473 |
||
|
Description
Renato Alves
2014-01-21 20:24:50 UTC
Created attachment 368406 [details, diff]
Ebuild changes between 2.2.0 and 2.3.0
Created attachment 368408 [details, diff]
rc directory changes for backwards compatibility with 2.2.0
There was a slight change in the CMakefile that required a new patch instead of the existing for task-2.0.0-beta4
Apart from the changes in the attached files, main features work as expected. The new task server related features (pull, push, merge, synchronize) were not tested. Created attachment 368458 [details, diff] Patch for task-2.3.0.ebuild I created a bump to 2.3.0 more or less at the same time as you, but did some things differently. Instead of patching around RCDIR, it is way easier to use it as described in the INSTALL file. All dirs are automatically prepended by CMAKE_INSTALL_PREFIX, so all definitions (TASK_{BIN,DOC,RC,MAN1,MAN5}DIR) need to be relative and not absolute. This boils down to simply fixing the usage of TASK_DOCDIR in the ebuild: - -DTASK_DOCDIR="${EPREFIX}"/usr/share/doc/${PF} + -DTASK_DOCDIR=share/doc/${PF} Besides that, the rcdir-patch can be removed now, as this issue was fixed upstream in http://taskwarrior.org/issues/1473 The result is the attached diff which is enough to make it work properly after bumping the ebuild to 2.3.0. Created attachment 368486 [details, diff]
Patch for task-2.3.0.ebuild
It turns out upstream missed a tiny detail in issue#1473 - doc/CmakeLists.txt still used TASK_DOCDIR to install the rc subdirectory which caused all the themefiles to still end up in TASK_DOCDIR and being compressed by Portage.
The current version of this patch addresses this issue - the required patch will be added next and was provided upstream in issue#1473.
Created attachment 368488 [details, diff]
Patch for addressing the rcdir issue from issue#1473
Just tested the new ebuild (applied patch and downloaded the other patch) on amd64 and it builds and works fine. committed, thanks! |
