Bug 49862

Summary:	linuxwacom-0.6.2.ebuild (Update)
Product:	Gentoo Linux	Reporter:	Torne Wuff <torne-gentoozilla>
Component:	New packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	torne-gentoozilla
Priority:	High
Version:	2004.1
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Diff from current ebuild Updated diff that actually works

Description Torne Wuff 2004-05-03 10:05:20 UTC

I've updated the linuxwacom ebuild to the latest upstream version and fixed a number of problems with the original ebuild. All the changes apply equally to the existing 0.6.0 ebuild - no changes are specific to 0.6.2.
Changes:
* Update upstream version to 0.6.2
* Add dependencies on gtk, tcl/tk, ncurses, pkgconfig, libtool
* Make use of gtk and tcl/tk conditional on USE flags (also use gtk2 flag)
* Make it actually work on xorg-x11 (the dependency had been changed but the ebuild checks for the 'sdk' USE flag in the packagedb and was only checking xfree)
* Remove building of XFree86 3.x driver as, well, we don't have 3.x. It was using the same X headers to build both the 4.x and 3.x versions anyway, which means that only the one matching the installed X version would've worked anyhow.
* Make ebuild install the provided documentation

I've run lintool over it and there are no errors/warnings.

Comment 1 Torne Wuff 2004-05-03 10:06:47 UTC

Created attachment 30616 [details, diff]
Diff from current ebuild

This is a diff as specified in the submission guideline doc, to make my changes
clear.

Comment 2 Torne Wuff 2004-05-03 10:10:19 UTC

Created attachment 30617 [details, diff]
Updated diff that actually works

I uploaded the wrong file. *thwacks forehead*

Comment 3 Donnie Berkholz (RETIRED) gentoo-dev

2004-05-06 08:26:37 UTC

Bryan, want to do this?

Comment 4 Bryan Stine (RETIRED) gentoo-dev

2004-05-08 21:09:59 UTC

Yes, I'll do this. Once I get my bearings straight (just moved back home from school) I can get CVS setup and bump it.

Comment 5 Bryan Stine (RETIRED) gentoo-dev

2004-05-10 11:50:07 UTC

Ok, bumped. Once the rsync mirrors catch up, you can sync to get it.

Comment 6 Bryan Stine (RETIRED) gentoo-dev

2004-05-10 15:00:37 UTC

A minor note or two...

In your DEPENDS, you used: gtk? ( gtk2? ( >=x11-libs/gtk+-2 ) : ( =x11-libs/gtk-1.2* ) ), this is deprecated syntax. Now we use something like: gtk? ( gtk2? ( >=x11-libs/gtk+-2 ) !gtk2 ( =x11-libs/gtk+-1.2* ) ), for the desired effect. I also added a missing + to the !gtk2 dependency. Evidently repoman and I both missed the syntax thing :-)

Thanks a lot for the added functionality in the ebuild, too.

Comment 7 Torne Wuff 2004-05-10 17:00:06 UTC

Thanks for that, I'll remember that next time. It's still listed in ebuild(5) without being marked as deprecated, though, and doesn't seem to be mentioned against in any of the developer documentation. Is there a document I'm missing, or are these things just 'general developer knowledge?'

Comment 8 Bryan Stine (RETIRED) gentoo-dev

2004-05-10 20:42:17 UTC

It was apparently mentioned on the gentoo-dev mailing list a while ago. I missed it too, so it's obviously not documented too well yet.