| Summary: | sys-apps/portage: etc-update should fall back to app-misc/editor-wrapper when user has not set $EDITOR | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Arthur D. <spinal.by> |
| Component: | Core - External Interaction | Assignee: | Portage team <dev-portage> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | CC: | alex_y_xu |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Proposed patch to fix the problem | ||
etc-update uses whatever is set as $EDITOR or $VISUAL. sudo clears these by default. consider "Defaults env_keep += EDITOR" or some other solution in /etc/sudoers. (In reply to Alex Xu (Hello71) from comment #1) > etc-update uses whatever is set as $EDITOR or $VISUAL. sudo clears these by > default. > > consider "Defaults env_keep += EDITOR" or some other solution in > /etc/sudoers. Regardless, the patch looks fine? -A (In reply to Alec Warner from comment #2) > (In reply to Alex Xu (Hello71) from comment #1) > > etc-update uses whatever is set as $EDITOR or $VISUAL. sudo clears these by > > default. > > > > consider "Defaults env_keep += EDITOR" or some other solution in > > /etc/sudoers. > > Regardless, the patch looks fine? > > -A No objections. (In reply to Alec Warner from comment #2) it is not. it doesn't support EPREFIX. (at least in prefix branch) portage_vars are retrieved through portageq, and EROOT is already in there, so we could just add EPREFIX, and use that I suppose. |
Created attachment 367534 [details, diff] Proposed patch to fix the problem I recently ran "sudo etc-update" and found this bug. Example output: ... 1) Replace /etc/conf.d/splash with merged file 2) Show differences between merged file and original 3) Remerge original with update 4) Edit merged file 5) Return to the previous menu Please select from the menu above (-1 to exit, losing this merge): 4 /usr/sbin/etc-update: line 506: nano: command not found ... I uninstalled nano few years ago and this package (sys-apps/portage) doesn't have nano in its dependencies. I suggest relying on /usr/libexec/editor instead of nano.