Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 494116

Summary: dev-lang/go-1.1.2 - backport archive/tar patches from 1.2
Product: Gentoo Linux Reporter: Tianon <admwiggin>
Component: [OLD] DevelopmentAssignee: William Hubbs <williamh>
Status: RESOLVED INVALID    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Tianon 2013-12-13 05:13:02 UTC
There are a couple bugs in Go's "archive/tar" package that were fixed in the commits between Go 1.1.2 and Go 1.2 (and thus are included in 1.2), but that can reasonably be included in 1.1.2.  These patches fix bugs that are affecting app-emulation/docker (which, up until the release of 1.2 has used a forked version of archive/tar that includes these patches to avoid this issue).  The relevant upstream commits are:

- archive/tar: Fix support for long links and improve PAX support.
  https://code.google.com/p/go/source/detail?r=0c7e4c45acf8

- archive/tar: fix a case where USTAR-split is not working correctly.
  https://code.google.com/p/go/source/detail?r=0d1b5f2ba0eb

For reference, Debian and RedHat have both included these patches in their Go 1.1.2 packages (see https://bugzilla.redhat.com/show_bug.cgi?id=1010271 and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=730566).

If it would be helpful, I am more than happy to attach direct patch files to this ticket.  Any information I can provide, or work I can do to be helpful, I'm happy to! :)  (Including writing a patch to the ebuild, if that's desirable/helpful!)

Reproducible: Always
Comment 1 William Hubbs gentoo-dev 2013-12-14 19:51:45 UTC
I just added go 1.2 to the tree, so do you think we should still
backport,?
Comment 2 Tianon 2013-12-16 16:49:38 UTC
Go 1.2 is sufficient indeed. :)  Thanks!