Summary: | games.eclass should set --datarootdir=/usr/share | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Eclasses | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | games.eclass.patch |
Description
Michał Górny
2013-12-11 19:04:14 UTC
a problem is that we can probably not fix this without breaking a lot of stuff, can we? I was suggesting to drop base.eclass inherit for EAPI=6 anyway... maybe we can fix this along with that? (In reply to Julian Ospald (hasufell) from comment #1) > a problem is that we can probably not fix this without breaking a lot of > stuff, can we? What stuff is going to be broken? I doubt many games actually use datarootdir at all, not to mention using it incorrectly. Old autoconf may be a problem but we can account for this with the usual '--help' check. (In reply to Michał Górny from comment #2) > (In reply to Julian Ospald (hasufell) from comment #1) > > a problem is that we can probably not fix this without breaking a lot of > > stuff, can we? > > What stuff is going to be broken? I doubt many games actually use > datarootdir at all, not to mention using it incorrectly. > > Old autoconf may be a problem but we can account for this with the usual > '--help' check. Then do a tinderbox run. I will add this option locally to the eclass and do random testing. Created attachment 365230 [details, diff]
games.eclass.patch
it seems the only one that actually "broke" was games-roguelike/angband... but the data files were misplaced in /usr/games/share anyway, so I fixed it I did not test gnome games ebuilds, but afais they do their own econf thing anyway Can someone from games team comment? I feel this is safe to apply. I will apply this in two weeks unless someone has objections. + 25 Jan 2014; Julian Ospald <hasufell@gentoo.org> games.eclass: + set --datarootdir=/usr/share wrt #493954 + |