Summary: | sys-apps/man-pages - Add subslots and depend on them in app-i18n/man-pages-de | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Markus Walter <gentoo> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | esigra, mrueg |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for sys-apps/man-pages
ebuild with subslot dependency |
Created attachment 364178 [details]
ebuild with subslot dependency
Comment on attachment 364176 [details, diff]
patch for sys-apps/man-pages
we're not doing EAPI=5 here yet, nor are we hardcoding $PV in a variable that could just as easily use $PV
the man-pages-de could just depend on ~man-pages-$PV and largely get the same behavior. i don't think it's critical enough to warrant bumping man-pages for now.
(In reply to SpanKY from comment #2) > Comment on attachment 364176 [details, diff] [details, diff] > patch for sys-apps/man-pages > > we're not doing EAPI=5 here yet, nor are we hardcoding $PV in a variable > that could just as easily use $PV > > the man-pages-de could just depend on ~man-pages-$PV and largely get the > same behavior. i don't think it's critical enough to warrant bumping > man-pages for now. Agreed, that SLOT="0/$PV" would be better. But depending on ~man-pages-$PV does not seem to be a good solution, since there is no correspondence between versions of man-pages and man-pages-de. Thus man-pages-de would have to be bumped needlessly with every man-pages release. Would moving to EAPI=5 hurt anything? remind me ... why is this necessary ? what does a subslot gain us here ? it's not link man-pages-de is "linking" against man-pages, or otherwise changes its output/installed files when man-pages upgrades. man-pages depends on man-pages-de when the user has the "de" language active, both of which would normally get upgraded during @world and such. (In reply to SpanKY from comment #4) > remind me ... why is this necessary ? what does a subslot gain us here ? > it's not link man-pages-de is "linking" against man-pages, or otherwise > changes its output/installed files when man-pages upgrades. > > man-pages depends on man-pages-de when the user has the "de" language > active, both of which would normally get upgraded during @world and such. In the past man-pages-de used the installed man-pages to generate the translations. This has changed in the meantime, so this is now obsolete. |
Created attachment 364176 [details, diff] patch for sys-apps/man-pages Don't know whether I should add a long introduction: I proxy-maintain man-pages-de. Adding subslots to man-pages requires an EAPI-bump. I searched the archives and it looks like this does not require a revbump. This can be accomplished with the attached patch. We then can add a subslot dependency on man-pages in man-pages-de as in the attached ebuild, which causes man-pages-de to be now in sync with man-pages.