Bug 49174

Summary:	locale_facets.h is incompatible with -fno-for-scope in gcc-3.4.0
Product:	Gentoo Linux	Reporter:	Robert Moss (RETIRED) <robmoss>
Component:	[OLD] GCC Porting	Assignee:	Gentoo Toolchain Maintainers <toolchain>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15090
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to fix behaviour of GCC 3.4.0 when used with -fno-for-scope

Description Robert Moss (RETIRED) gentoo-dev

2004-04-27 08:55:09 UTC

See title. This causes compile errors with anything that uses -fno-for-scope, such as openoffice. This patch needs to be applied (for those of you who've already installed GCC, you can just apply this against /usr/lib/gcc-lib/i686-pc-linux-gnu/3.4.0/include/g++-v3/bits/locale_facets.h) before attempts to get OOo compiling with 3.4.0 can even begin, as OOo requires the use of -fno-for-scope. Note that this doesn't regress anything as far as I can tell, it just fixes the behaviour of locale_facets.h when used with -fno-for-scope, and doesn't alter it when used with the default -ffor-scope.

Reproducible: Always
Steps to Reproduce:
1. See upstream bug for example problem code.
Actual Results:  
It broke :-P

Expected Results:  
It shouldn't have broke :-P

Seriously, though - the error message is also upstream.

Comment 1 Robert Moss (RETIRED) gentoo-dev

2004-04-27 09:00:11 UTC

Created attachment 30159 [details, diff]
Patch to fix behaviour of GCC 3.4.0 when used with -fno-for-scope

Comment 2 Travis Tilley (RETIRED) gentoo-dev

2004-04-27 16:25:57 UTC

this is a toolchain bug, not a bug in an app that needs porting. thankyou for submitting this patch, i'll send a friend who is trying to get OO working on x86 to this bug and have him see if this helps. as for OO... i cant really help there, as OO doesnt even attempt to compile on amd64.

Comment 3 Robert Moss (RETIRED) gentoo-dev

2004-04-27 16:39:05 UTC

Sorry about that. This is obviously a toolchain bug rather than a gcc-porting one. I just clicked on "GCC 3" in the list without really thinking. I'm pushing quite hard trying to get OOo working on x86, but haven't had much luck as yet. I've managed to get round the STLport problems, granted, but I've not yet really got too far beyond that.

Comment 4 Travis Tilley (RETIRED) gentoo-dev

2004-04-28 15:29:33 UTC

ok, i've committed the patch. it doesnt seem to break anything, so it cant hurt to include it. give it a little time to reach rsync.