Bug 491222 – sys-libs/talloc support for multiple ABIs

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kenneth Graunke 2013-11-14 05:27:02 UTC]

I needed both amd64 and i686 versions of sys-libs/talloc for a project I'm working on, so I updated the ebuild to use the multilib-minimal eclass.

Reproducible: Always

[Comment 1 Kenneth Graunke 2013-11-14 05:28:21 UTC]

Created attachment 363236 [details]
talloc ebuild with multilib support

The emul-x86-baselibs line probably is wrong, but otherwise this is working great on my system.

Looking forward to any feedback you have!  Thanks.

[Comment 2 Alexis Ballier 2013-11-14 08:04:10 UTC]

	ECONF_SOURCE=${S} \
	waf-utils_src_configure \
		${extra_opts}

I don't think the ECONF_SOURCE line is needed

otherwise LGTM; there's probably no hope to make waf work with out of source builds...

[Comment 3 Kenneth Graunke 2013-11-14 20:21:26 UTC]

You're right - it works fine without ECONF_SOURCE=${S}.  Must've been left over from one of my earlier attempts to get this working.

[Comment 4 Kenneth Graunke 2013-12-21 06:22:00 UTC]

Alexis, Patrick, any updates here?  Are there changes you'd like me to make?  Or should it be committed?  Thanks!

[Comment 5 Víctor Ostorga (RETIRED) 2014-02-01 20:51:00 UTC]

+  01 Feb 2014; Victor Ostorga talloc-2.1.0.ebuild:
+  Adding multilib support, bug #491222 , patch thanks to Kenneth Graunke
+  <[e-mail]>
+

[Comment 6 Matt Turner 2014-02-01 22:05:59 UTC]

Created attachment 369298 [details]
build.log

(In reply to Víctor Ostorga from comment #5)
> +  01 Feb 2014; Victor Ostorga talloc-2.1.0.ebuild:
> +  Adding multilib support, bug #491222 , patch thanks to Kenneth Graunke
> +  <[e-mail]>
> +

A number of problems:
- The blocking dependency on -baselibs is wrong, namely because
- there's no updated -baselibs without talloc, but not to worry because
- multilib'd talloc-2.1.0 fails during install. See the build log.

And while I'm piling it on you... ;)
- Your changelog entry doesn't include your email (this appears a number of time in portage)

[Comment 7 Víctor Ostorga (RETIRED) 2014-02-02 15:33:23 UTC]

*** Bug 500042 has been marked as a duplicate of this bug. ***

[Comment 8 Víctor Ostorga (RETIRED) 2014-02-02 17:48:22 UTC]

Created attachment 369368 [details, diff]
Adding multilib support to talloc-2.1.0

Attached is a working patch that allows building talloc with multilib support.

I have reverted the commit to talloc-2.1.0 because as Matt said, emul-linux-x86-baselibs provides talloc, and that creates file conflicts. Until the baselibs are updated, I will commit the patch.

@Matt:
I will pay attention to the ChangeLog entries, thanks for the heads up

[Comment 9 Michał Górny 2014-05-14 22:58:45 UTC]

+*talloc-2.1.0-r1 (14 May 2014)
+
+  14 May 2014; Michał Górny <[e-mail]> +talloc-2.1.0-r1.ebuild:
+  Enable multilib support, bug #491222. Clean up Python deps.

p.masked as usual, open to review & suggestions.