Bug 49040

Summary:	Adding skey USE flag to sudo >= 1.6.6
Product:	Gentoo Linux	Reporter:	Ti Leggett <leggett>
Component:	New packages	Assignee:	Tavis Ormandy (RETIRED) <taviso>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	sudo with IUSE=skey, also cleaned up a little corrected

Description Ti Leggett 2004-04-26 09:09:16 UTC

sudo since at least version 1.6.6 has had s/key support for it. Can sudo get a skey USE flag added that enables this support?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1 Eric Brown 2004-04-26 12:54:12 UTC

Created attachment 30107 [details]
sudo with IUSE=skey, also cleaned up a little

changed use pam && myconf="--with-pam" || myconf="--without-pam" to
myconf="`use_with pam pam`"

also the skey flag was added

Comment 2 Ti Leggett 2004-04-26 13:25:42 UTC

One minor addition. Shouldn't:

DEPEND="pam? ( >=sys-libs/pam-0.73-r1 )"

be

DEPEND="pam? ( >=sys-libs/pam-0.73-r1 )
    skey? ( >=app-admin/skey-1.1.5-r1 )"

Comment 3 Eric Brown 2004-04-26 15:31:54 UTC

Created attachment 30115 [details]
corrected

Comment 4 Ti Leggett 2004-04-26 16:51:44 UTC

Heh. Missed this in the first pass:

Replace:
	use skey \
		&& myconf=" --with-skey"

with:
	myconf="${myconf} `use_with skey skey`"

Otherwise your --with(out)-pam configure option will be wiped.

Comment 5 Tavis Ormandy (RETIRED) gentoo-dev

2004-09-17 12:45:41 UTC

sudo wont support pam with other authorisation methods, even though it decides to link with -lskey.

you can see in sudo_auth.c, if pam is enabled, everything else is ignored.

So I'll add support for it and add an einfo that says pam + skey is bad, I've tried it out and it works okay here.

Thanks for the suggestion guys.