| Summary: | app-shells/fish-2.1.0 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Elis Axelsson <elis.axelsson> |
| Component: | New packages | Assignee: | Jeff (JD) Horelick (RETIRED) <jdhore> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | polynomial-c |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 488518 | ||
| Attachments: |
Ebuild for fish 2.1.0
Patch that fixes the docdir bug diff -u of my new ebuild for fish |
||
|
Description
Elis Axelsson
2013-10-28 09:20:00 UTC
Created attachment 362116 [details]
Ebuild for fish 2.1.0
I been using it on the testing version of fish 2.1.0 and it seems to be fine.
Changes I made was to remove the part where we specified docdir to econf to be /usr/share/doc/fish-2.1.0/ since several fish-scripts/functions expects the docs to be in /usr/share/doc/fish/ (for example the function "help"). This should be considered as a bug in fish. But the same bug was there in the 2.0.0 release.
I also removed the declaration of $S, since it seems to not be needed for this release.
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for us. Gentoo policy says that a package must install its docs into /usr/share/doc/packagename-fullversion/ So removing this from the ebuild is the wrong approach. Rather fix the scripts which don't respect the docdir variable. Linked this issue on fish-irc, and the devs noticed the docdir part and reported it themselfs: https://github.com/fish-shell/fish-shell/issues/1065 It won't be fixed before 2.2.0, but I could backport it when they patch it. I will also submit a diff -u when I got a patch for this issue. (In reply to Elis Axelsson from comment #3) > Linked this issue on fish-irc, and the devs noticed the docdir part and > reported it themselfs: https://github.com/fish-shell/fish-shell/issues/1065 > > It won't be fixed before 2.2.0, but I could backport it when they patch it. > I will also submit a diff -u when I got a patch for this issue. Thank you for reporting this issue upstream. :) Created attachment 362154 [details, diff]
Patch that fixes the docdir bug
These changes was commited upstream earlier today, they fix the docdir bug.
Created attachment 362156 [details, diff]
diff -u of my new ebuild for fish
Added the usage of the patch submited in previous comment.
|
