Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 489430

Summary: media-libs/hal-flash should depend on sys-fs/udisks (without SLOT dependency)
Product: Gentoo Linux Reporter: Ooblick <ooblick>
Component: [OLD] LibraryAssignee: Samuli Suominen (RETIRED) <ssuominen>
Status: RESOLVED INVALID    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch to remove slot dependency on udisks-1

Description Ooblick 2013-10-26 07:35:15 UTC
Created attachment 361948 [details, diff]
patch to remove slot dependency on udisks-1

Currently hal-flash depends upon slot :0 for udisks, with will attempt to install udisks-1.0.4. hal-flash will successfully compile and run (tested on http://www.channel4.com/programmes/4od) with udisks-2.1.1. Please remove the slot dependency to prevent old versions being installed.
Comment 1 Rafał Mużyło 2013-10-26 18:47:45 UTC
:roll:
It's pretty much impossible to get a build error, the way udisks are used by this package.
Nevertheless, the calls used come from udisks:0, so it it works without it, it's only by chance.

Though if it does, there might be a room for improvement for hal-flash - that is moving it further into becoming a stub.
Comment 2 Ooblick 2013-10-26 19:06:57 UTC
Just to confirm - it's more than just the absence of build errors. Without hal-flash a 4od video will sit forever in the "loading" phase - which is indicating it's attempting to confirm the drm. With hal-flash built against udisks-2.1.1, the video loads straight away. I've just checked this with http://www.channel4.com/programmes/location-location-location/4od#3587618.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-10-26 19:55:02 UTC
the package calls org.freedesktop.UDisks

src/libhal.c:#define DBUS_IFACE_UDISKS_DEVICE "org.freedesktop.UDisks.Device"

and it's provided by sys-fs/udisks from SLOT="0":

/usr/share/dbus-1/system-services/org.freedesktop.UDisks.service

not by UDisks2
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-10-26 19:56:23 UTC
/usr/share/dbus-1/system-services/org.freedesktop.UDisks2.service doesn't match, as provided by sys-fs/udisks:2
Comment 5 Rafał Mużyło 2013-10-27 00:23:10 UTC
Actually my point was that the interface is different, for example there's no EnumerateDevices equivalent in udisks2.