Bug 489310 – Make emerge not delete files when --ask

• Product: Portage Development
• Status: UNCONFIRMED ---

[Description Alexander Berntsen (RETIRED) 2013-10-24 20:09:54 UTC]

When --ask, the following prompt should be made interactive

 *
 * Searching all installed packages for file collisions...
 * 
 * Press Ctrl-C to Stop
 * 

emerge should not delete files automatically when --ask.

[Comment 1 Sebastian Luther (few) 2013-11-21 11:40:09 UTC]

Please no interactivity after the dependency resolution.

What you propose could interrupt an several hour long session without anyone watching.

[Comment 2 Alexander Berntsen (RETIRED) 2013-11-21 11:42:04 UTC]

Then add a different option for it. I still think it's fine to do it when --ask though.

[Comment 3 Sebastian Luther (few) 2013-11-21 11:53:07 UTC]

(In reply to Alexander Berntsen from comment #2)
> Then add a different option for it. I still think it's fine to do it when
> --ask though.

I guess you want FEATURES="collision-protect" instead of the default protect-owned (see man make.conf).

In the past, collision-protect was the default, but it was changed some years ago. Maybe there is a bug somewhere.

[Comment 4 Alexander Berntsen (RETIRED) 2013-11-21 11:59:15 UTC]

(In reply to Sebastian Luther (few) from comment #3)
> I guess you want FEATURES="collision-protect" instead of the default
> protect-owned (see man make.conf).
> 
> In the past, collision-protect was the default, but it was changed some
> years ago. Maybe there is a bug somewhere.

I had not considered this. It was probably changed for a reason, so I won't comment directly on whether this specific change should be made. However, I maintain that files shouldn't be deleted by default.

[Comment 5 Sebastian Luther (few) 2013-11-21 12:11:10 UTC]

(In reply to Alexander Berntsen from comment #4)
> (In reply to Sebastian Luther (few) from comment #3)
> > I guess you want FEATURES="collision-protect" instead of the default
> > protect-owned (see man make.conf).
> > 
> > In the past, collision-protect was the default, but it was changed some
> > years ago. Maybe there is a bug somewhere.
> 
> I had not considered this. It was probably changed for a reason, so I won't
> comment directly on whether this specific change should be made. However, I
> maintain that files shouldn't be deleted by default.

I'm a bit confused. You say "delete", but in case of file collisions it's about overwriting (which you may find equally bad). Am I missing something?

And I have to repeat comment 1. This discussion has come up several times over the years and the end result was always not to add interactivity after the dependency resolution.

If you don't want the current behavior as default, then re-start the discussion about collision-protect vs protect-owned.

[Comment 6 Alexander Berntsen (RETIRED) 2013-11-21 12:16:45 UTC]

(In reply to Sebastian Luther (few) from comment #5)
> I'm a bit confused. You say "delete", but in case of file collisions it's
> about overwriting (which you may find equally bad). Am I missing something?
I was mixing two topics because I was distracted; sorry. I believe I was mixing the deletion of orphaned files with overwriting.

> And I have to repeat comment 1. This discussion has come up several times
> over the years and the end result was always not to add interactivity after
> the dependency resolution.
I disagree with the conclusion and don't think that discussions are not worth revisiting. However, I should have found one of these old discussions instead of opening a new one.

> If you don't want the current behavior as default, then re-start the
> discussion about collision-protect vs protect-owned.
OK.