Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 489158

Summary: net-misc/owncloud-client: use system copy of dev-qt/qtsingleapplication
Product: Gentoo Linux Reporter: Nikoli <nikoli>
Component: Current packagesAssignee: Bernard Cafarelli <voyageur>
Status: CONFIRMED ---    
Severity: normal CC: dan, dschridde+gentoobugs, endymion+gentoo, esigra, karl.j.linden, kripton, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 251464    

Description Nikoli 2013-10-23 14:39:15 UTC
mirall-1.4.0 $ grep qtsingleapplication src/CMakeLists.txt -a1
set(3rdparty_SRC
3rdparty/qtsingleapplication/qtsingleapplication.cpp
3rdparty/qtsingleapplication/qtlocalpeer.cpp
3rdparty/qtsingleapplication/qtsinglecoreapplication.cpp
3rdparty/qtlockedfile/qtlockedfile.cpp
--
set(3rdparty_HEADER
3rdparty/qtsingleapplication/qtlocalpeer.h
3rdparty/qtsingleapplication/qtsingleapplication.h
3rdparty/qtsingleapplication/qtsinglecoreapplication.h
3rdparty/fancylineedit/fancylineedit.h
--
    ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/qtlockedfile
    ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/qtsingleapplication
    ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/QProgressIndicator

Build system needs patching.
Comment 1 Johannes Huber (RETIRED) gentoo-dev 2013-10-23 21:17:56 UTC
(In reply to Nikoli from comment #0)
> mirall-1.4.0 $ grep qtsingleapplication src/CMakeLists.txt -a1
> set(3rdparty_SRC
> 3rdparty/qtsingleapplication/qtsingleapplication.cpp
> 3rdparty/qtsingleapplication/qtlocalpeer.cpp
> 3rdparty/qtsingleapplication/qtsinglecoreapplication.cpp
> 3rdparty/qtlockedfile/qtlockedfile.cpp
> --
> set(3rdparty_HEADER
> 3rdparty/qtsingleapplication/qtlocalpeer.h
> 3rdparty/qtsingleapplication/qtsingleapplication.h
> 3rdparty/qtsingleapplication/qtsinglecoreapplication.h
> 3rdparty/fancylineedit/fancylineedit.h
> --
>     ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/qtlockedfile
>     ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/qtsingleapplication
>     ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/QProgressIndicator
> 
> Build system needs patching.

Which means the whole directory "3rdparty/qtsingleapplication" can be removed. These changes needs upstreaming as we dont want to have this patch forever maintained downstream.
Comment 2 Dennis Schridde 2013-12-26 15:23:21 UTC
(In reply to Nikoli from comment #0)
> Build system needs patching.

Does a patch exist, yet? It would be nice to integrate this into the net-misc/mirall-1.5.0 bump. (I bumped it as net-misc/owncloud-client-1.5.0 in the KDE overlay.)