| Summary: | x11-misc/kdocker: use system copy of dev-qt/qtsingleapplication | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Nikoli <nikoli> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugs.launchpad.net/kdocker/+bug/1243955 | ||
| Whiteboard: | tracking upstream | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 251464 | ||
|
Description
Nikoli
2013-10-23 13:41:34 UTC
(In reply to Nikoli from comment #0) > kdocker-4.8 $ grep qtsingleapplication kdocker.pro > include(solutions/qtsingleapplication/qtsingleapplication.pri) > > Build system needs patching. Which means the whole directory "solutions/qtsingleapplication" can be removed. These changes needs upstreaming as we dont want to have this patch forever maintained downstream. Upstreams will not accept patches making usage of internal copy impossible. Bundled libs exist for a reason, so you should make them optional, but not remove. Example of patch which adds ability to build with both system and internal lib: https://code.google.com/p/quite-rss/source/detail?r=eb1892cbe9a0 (In reply to Nikoli from comment #2) > Upstreams will not accept patches making usage of internal copy impossible. > Bundled libs exist for a reason, so you should make them optional, but not > remove. > > Example of patch which adds ability to build with both system and internal > lib: > https://code.google.com/p/quite-rss/source/detail?r=eb1892cbe9a0 Please dont every line you change in a patch has risk to create more downstream work. And following the KISS principal this should be avoided. Whether you want to build the package with external then the bug is valid otherwise it is not. You are correct, but for now it is not possible yet to avoid this evil: Not all distros have qtsingleapplication package, seems most do not have it now. Debian and Ubuntu still did not package it and are not willing to. Upstreams need to support not only Gentoo, Fedora and Alt Linux, but also Debian based distros. Thanks for reporting. This is fixed in cvs now. Please sync in some hours to get the changes. + + 27 Oct 2013; Johannes Huber <johu@gentoo.org> + +files/kdocker-4.8-unbundle-qtsingleapplication.patch, +kdocker-4.8-r1.ebuild: + Revision bump uses system qtsingleapplication instead of bundled lib wrt bug + #489146. + |
