Summary: | media-libs/harfbuzz - add multilib support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andrew Church <achurch+gentoo> |
Component: | [OLD] Library | Assignee: | Gentoo Office Team <office> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gnome, multilib+disabled |
Priority: | Normal | Keywords: | PATCH, PMASKED |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 480422, 488860 | ||
Bug Blocks: | 454644, 488868 | ||
Attachments: |
harfbuzz-0.9.20.ebuild.patch
harfbuzz-0.9.23.ebuild.patch harfbuzz-0.9.23.ebuild.patch |
We need a multilib icu first - see bug #480422 (In reply to Alexandre Rostovtsev from comment #1) > We need a multilib icu first - see bug #480422 multilib icu done, please go ahead with the review. (In reply to Christoph Junghans from comment #2) > multilib icu done, please go ahead with the review. Is this urgent? I would prefer to wait for multilib graphite2 (bug #488860), but I suppose we could temporarily add this with graphite disabled for non-native ABIs. Harfbuzz needs graphite to support Silf tables in fonts for non-Western writing systems, but I don't think that such fonts are very common at the moment. (In reply to Andrew Church from comment #0) (In reply to Christoph Junghans from comment #2) Quick review: cairo is used only for command-line utils, so we don't need a multilib dep on it, and it should only be enabled for native ABI. introspection should be enabled only for native ABI; we don't need 32-bit python or javascript bindings on amd64. Created attachment 366596 [details, diff] harfbuzz-0.9.23.ebuild.patch Thanks for the review. >cairo is used only for command-line utils, so we don't need a multilib dep on >it, and it should only be enabled for native ABI. Fixed. >introspection should be enabled only for native ABI; we don't need 32-bit >python or javascript bindings on amd64. I was aware of that, but apparently I overlooked it for this package. Fixed, thanks for catching that. This patch looks really nice and clean. Created attachment 366676 [details, diff]
harfbuzz-0.9.23.ebuild.patch
Oops, I just realized I accidentally deleted the := on the cairo dep when I removed ${MULTILIB_USEDEP}. Fixed in this version of the patch.
+*harfbuzz-0.9.26-r1 (01 Mar 2014) + + 01 Mar 2014; Michał Górny <mgorny@gentoo.org> +harfbuzz-0.9.26-r1.ebuild: + Introduce multilib support as a dependency of pango, bug #488864. Committed p.masked, feel free to comment before it is unmasked. (In reply to Michał Górny from comment #8) > Committed p.masked, feel free to comment before it is unmasked. Ack from maintainer. Can be unmasked as soon as graphite2 is. |
Created attachment 361508 [details, diff] harfbuzz-0.9.20.ebuild.patch Dependency of GTK+ via pango.