Bug 488646 – =media-video/vlc-9999 - Fix Qt5 build, patch attached

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description David Heidelberg (okias) 2013-10-19 22:11:47 UTC]

Reference fixed ebuild, with workaround for qt5 [1].
[1] https://github.com/okias/ixit/tree/master/media-video/vlc

Reproducible: Always

Steps to Reproduce:
1. install qtcore:5 and qtgui:5
2. emerge -v =vlc-9999
3. notice, that vlc detect qt 5.x.y
Actual Results:  
VLC use MOC from /usr/bin/moc and/or UIC from /usr/bin/uic, which refers to 4.8.x version.
This behaviour end with compilation fail, because from .ui files is code generated by Qt:4 instead detected Qt:5


Expected Results:  
VLC should USE qt4 and qt5. In case QT5 use, for this moment I avoided fail by exporting UIC and MOC and replacing path (hardcoding to qt5).

[Comment 1 Tom Wijsman (TomWij) (RETIRED) 2013-10-19 22:38:52 UTC]

Created attachment 361362 [details, diff]
vlc-9999.patch

Patch by comparing ebuild from overlay against ebuild in the Portage tree.

[Comment 2 Tom Wijsman (TomWij) (RETIRED) 2013-10-19 22:48:52 UTC]

@scarabeus: See #gentoo-desktop ping.

@media-video: Are you looking for a dedicated maintainer for this package?

[Comment 3 Tom Wijsman (TomWij) (RETIRED) 2013-10-21 01:25:36 UTC]

Will try to evaluate this tomorrow.

[Comment 4 Tom Wijsman (TomWij) (RETIRED) 2013-10-21 18:23:17 UTC]

For this to be introduced qtcore:5 and qtgui:5 first have to make it to the Portage tree.

  dependency.badmasked          2                                                                  
   media-video/vlc/vlc-9999.ebuild: DEPEND: **(empty profile) ['dev-qt/qtgui:5', 'dev-qt/qtcore:5']
   media-video/vlc/vlc-9999.ebuild: RDEPEND: **(empty profile) ['dev-qt/qtgui:5', 'dev-qt/qtcore:5']

Regardless, I agree to add it under a slightly modified version of your patch once it hits the Portage tree; until then we'll have to wait for the tracker bug.

[Comment 5 Tom Wijsman (TomWij) (RETIRED) 2013-10-21 19:15:42 UTC]

Actually, due to the USE flag being masked I can actually add it without the need for it to be present in the Portage tree; this was discussed with other Gentoo Developers on our IRC channel (#gentoo-dev).

This work is part of the following commit:

+  21 Oct 2013; Tom Wijsman <[e-mail]>
+  -files/vlc-2.1.0-freetype-proper-default-font.patch, metadata.xml,
+  vlc-9999.ebuild:
+  Worked further on the 2.1.0 version bump: Added USE flags and dependencies to
+  support fdk(aac), opus, tremor, vdpau and vpx. Added support for the upcming
+  Qt 5 release. Added missing dependencies (libgpg-error used in HTML
+  communication, libidn which is used by most objects, gdb-pixbuf, glib and xcb-
+  util-keysyms) SLOTted all dependencies, used the slot operator where
+  dependencies have sub slots; to avoid incorrect dependencies, new SLOTs and
+  overlays versions from breaking the vlc package. Moved gettext to RDEPEND as
+  it was duplicated. Remove _FORTIFY_SOURCE definition as it is set to Gentoo's
+  default to shorten the build log by removing unnecessary warnings. Removed the
+  freetype patch as the configure parameters work. Ensured that there are less
+  to none automagic dependencies. Enumerated almost all configure parameters as
+  there were some missing. Removed oss due to compile error due to missing
+  package. Run tests using virtualx to avoid a window from popping up.
+  Simplified src_install. Documented fdk, tremor and vpx USE flags in
+  metadata.xml. More changes and testing will follow; there still appear
+  warnings and errors to look into (also resid_builder), which probably requires
+  configure.ac patching. Progress is being tracked mainly in bug #479566.

Thank you for your contribution.

[Comment 6 David Heidelberg (okias) 2013-10-21 22:12:33 UTC]

Thank you, marking as fixed.