| Summary: | media-libs/sdl-mixer-1.2.12: cherry-pick a few fixes from 2.0 branch | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Rafał Mużyło <galtgendo> |
| Component: | [OLD] Library | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED NEEDINFO | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
cherry-picked fixes for 1.2 branch
updated patch another update (rev8ef083375857 ) updated patch (rev dd498db4e82e) |
||
those should be separate patches generated from their hg commits, not just dumped into one file, so people can read who did it and why (In reply to Julian Ospald (hasufell) from comment #1) > those should be separate patches generated from their hg commits, not just > dumped into one file, so people can read who did it and why Call that me being lazy. There's also the thing, that a few commits on 2.0 branch mixed actual and whitespace changes in a single commit. http://hg.libsdl.org/SDL_mixer/rev/ea53a85853dd * http://hg.libsdl.org/SDL_mixer/rev/f2943eac3fd7 * http://hg.libsdl.org/SDL_mixer/rev/a4e9c53d9c30 * http://hg.libsdl.org/SDL_mixer/rev/e795460706d0 http://hg.libsdl.org/SDL_mixer/rev/7ead8213dfb0 http://hg.libsdl.org/SDL_mixer/rev/0ff9b7b8ba7b http://hg.libsdl.org/SDL_mixer/rev/030181ff9f59 http://hg.libsdl.org/SDL_mixer/rev/bd8389c6dd20 http://hg.libsdl.org/SDL_mixer/rev/8b25e64c7ac7 those marked with (*) are on 1.2 branch) Created attachment 362524 [details, diff] updated patch ...added http://hg.libsdl.org/SDL_mixer/rev/8ef083375857 ( it's a correction of http://hg.libsdl.org/SDL_mixer/rev/0ff9b7b8ba7b). (In reply to Rafał Mużyło from comment #2) > (In reply to Julian Ospald (hasufell) from comment #1) > > those should be separate patches generated from their hg commits, not just > > dumped into one file, so people can read who did it and why > > Call that me being lazy. > There's also the thing, that a few commits on 2.0 branch mixed actual and > whitespace changes in a single commit. > Then you still create separate files with at least a link to the original commit. reopen if you feel like splitting the patches. The fixes doesn't look pressing enough to me, but that's what's great about OSS: people get to spend their time how they want. ;-) Created attachment 380290 [details, diff]
another update (rev8ef083375857 )
Created attachment 380292 [details, diff]
updated patch (rev dd498db4e82e)
Sorry, attached the wrong file.
|
Created attachment 360994 [details, diff] cherry-picked fixes for 1.2 branch It seems that the upstream isn't backporting 2.0 fixes, that are still valid for 1.2 branch (at least going by that that sorry excuse for a web interface mercurial has). In the attached patch I hope I've picked all of those still valid for 1.2 and only those. One of those fixes is for a leak, another for a crasher, so it might be worth getting them into the tree.