Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 487778

Summary: =games-emulation/sdl{mame,mess}-0.148_p1 - gconf dependencies unneeded -> use gnome flag
Product: Gentoo Linux Reporter: Samuel Bauer <samuel.bauer>
Component: [OLD] GamesAssignee: Gentoo Games <games>
Status: RESOLVED OBSOLETE    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: sdlmame-0.148_p1-no_gconf.patch
sdlmame-0.148_p1-r1.ebuild.patch
sdlmess-0.148_p1.ebuild.patch

Description Samuel Bauer 2013-10-12 12:51:56 UTC
Created attachment 360690 [details, diff]
sdlmame-0.148_p1-no_gconf.patch

there's a compile dependency to gconf for sdlmame/sdlmess.
gconf is only used one time in the whole project to seek a user font set in gnome preference, else it uses a default font.
Here's a patch to the project to allow to disable dependencies to gconf, and patch to the ebuild to use gnome flag for the people who usually uses it.
Apllies both for sdlmame and sdlmess as they share same code.
Comment 1 Samuel Bauer 2013-10-12 12:55:02 UTC
Created attachment 360692 [details, diff]
sdlmame-0.148_p1-r1.ebuild.patch
Comment 2 Samuel Bauer 2013-10-12 12:56:07 UTC
Created attachment 360694 [details, diff]
sdlmess-0.148_p1.ebuild.patch
Comment 3 Julian Ospald 2013-10-12 13:27:46 UTC
I doubt that upstream will accept this patch. You should provide proper conditionals in the code.
Comment 4 Samuel Bauer 2013-10-12 13:41:15 UTC
Your doubt are highly funded, that's not intended for upstream.
I'm also planning to do a patch intended for upstream.
Comment 5 Mr. Bones. (RETIRED) gentoo-dev 2015-11-20 06:57:05 UTC
sdlmame-0.167 is in the tree so we'll leave 0.148 alone.