Bug 487718

Summary:	=media-libs/xine-lib-1.2.3 - video_out_vaapi.c:2083:3: error: implicit declaration of function ‘av_free’ [-We rror=implicit-function-declaration]
Product:	Gentoo Linux	Reporter:	Matthias Bethke <matthias>
Component:	[OLD] Library	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	CC:	matthias
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	emerge --info =media-libs/xine-lib-1.2.3 Fix for video_out_vaapi.c

Description Matthias Bethke 2013-10-12 02:30:02 UTC

Compilation fails with this error and a few related ones:

video_out_vaapi.c: In function ‘vaapi_frame_dispose’:
video_out_vaapi.c:2083:3: error: implicit declaration of function ‘av_free’ [-We
rror=implicit-function-declaration]

This is due to a missing include in video_out_vaapi.c that was probably made necessary by the split between ffmpeg and libav. Strangely enough it doesn't seem to depend on USE=vaapi. I'm attaching a trivial patch to fix it.


Reproducible: Always

Steps to Reproduce:
1. emerge media-libs/xine-lib-1.2.3
2.
3.
Actual Results:  
Compilation fails with the above error message

Expected Results:  
Package compiled successfully

Comment 1 Matthias Bethke 2013-10-12 02:31:36 UTC

Created attachment 360678 [details]
emerge --info =media-libs/xine-lib-1.2.3

Comment 2 Matthias Bethke 2013-10-12 02:32:46 UTC

Created attachment 360680 [details, diff]
Fix for video_out_vaapi.c

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2014-06-22 17:47:22 UTC

I see this code in xine-lib-1.2.5, so nothing left to do here, closing as FIXED