Bug 487540

Summary:	app-emulation/q4wine: use system copy of dev-qt/qtsingleapplication
Product:	Gentoo Linux	Reporter:	Nikoli <nikoli>
Component:	New packages	Assignee:	Markos Chandras (RETIRED) <hwoarang>
Status:	RESOLVED FIXED
Severity:	normal	CC:	brezerk, esigra, qt
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/brezerk/q4wine/issues/39
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	251464
Attachments:	Add /usr/include/qt4 to find_path cmake call for QtSingleApplication search

Description Nikoli 2013-10-10 15:26:17 UTC

q4wine-1.0-r3 $ grep WITH_SYSTEM src/CMakeLists.txt
option(WITH_SYSTEM_SINGLEAPP "If ON, then use system QtSingleApplication library instead building one." "OFF")

Seems this option works fine for fedora:
https://apps.fedoraproject.org/packages/q4wine/sources/spec/

Comment 1 Markos Chandras (RETIRED) gentoo-dev

2013-10-13 11:53:55 UTC

Hmm it does not seem to work

-- Searching for QtSingleApplication package (WITH_SYSTEM_SINGLEAPP=ON) --

--      library : NOT FOUND!

CMake Error at src/CMakeLists.txt:290 (MESSAGE):
  Please install SingleApplication Library or disable system qtsingleapp
  support by adding -DWITH_SYSTEM_SINGLEAPP=OFF" option to cmake"

qtsingleapplication is installed on my box

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2013-10-13 13:26:50 UTC

Lets CC upstream maintainer

Comment 3 John Brezerk 2013-10-14 06:55:49 UTC

Created attachment 360850 [details, diff]
Add /usr/include/qt4 to find_path cmake call for QtSingleApplication search

Hi Markos,

It seems like on Gentoo QtSingleApplication's headers are installed into /usr/include/qt4 direcotry rather then /usr/include/ like on the other systems. 

It ok, I have created a patch, please try it.

If it works for you, I'll add it into main repository, but I will need some time to ensure that it will not break compilation on other systems :)

Thanks

Comment 4 Markos Chandras (RETIRED) gentoo-dev

2013-10-14 07:47:08 UTC

I wonder if the Qt can help with that. Maybe we do something wrong? You could have a look on what qbittorrent is doing because it's also a Qt4 app and works ok with the system qtsingleapplication.

Thanks for the patch. I will try it asap

Comment 5 John Brezerk 2013-10-14 09:47:17 UTC

I am fine with /usr/include/qt4. However some examples of cmake's 3party plugins for QtSingleApplication did not respect it.

jfyi: created bug in project's tracker: https://github.com/brezerk/q4wine/issues/39

Comment 6 Markos Chandras (RETIRED) gentoo-dev

2013-10-14 18:57:22 UTC

+*q4wine-1.0_p3-r1 (14 Oct 2013)
+
+  14 Oct 2013; Markos Chandras <hwoarang@gentoo.org>
+  +files/q4wine-qtsingleapp.patch, +q4wine-1.0_p3-r1.ebuild:
+  Revbump to use system's qtsingleapplication package. Bug #487540. Patch by
+  John Brezerk <brezerk@gmail.com>. Also change package version format to comply
+  with portage standards
+