Bug 487262

Summary:	git-r3.eclass checks out submodules with update=none
Product:	Gentoo Linux	Reporter:	Davide Pesavento <pesa>
Component:	Eclasses	Assignee:	Michał Górny <mgorny>
Status:	VERIFIED FIXED
Severity:	normal	CC:	qt
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	git-r3.eclass patch

Description Davide Pesavento (RETIRED) gentoo-dev

2013-10-08 00:34:54 UTC

I need to disable submodules for https://qt.gitorious.org/qt/qtdeclarative

Comment 1 Davide Pesavento (RETIRED) gentoo-dev

2013-10-08 00:39:24 UTC

Or maybe the eclass should automatically skip submodules that have "update = none" in .gitmodules, but TBH I'm not sure if I really understood the purpose of that configuration key.

Comment 2 Michał Górny archtester

2013-10-08 03:54:42 UTC

Hmm, supporting that seems reasonable. I see that git-submodule does exactly that.

Comment 3 Michał Górny archtester

2013-10-09 15:00:15 UTC

Created attachment 360496 [details, diff]
git-r3.eclass patch

Could you test this patch, please? A dummy ebuild using qtdeclarative's EGIT_REPO_URI seems to work fine (not fetch the submodule) but I'd like you to confirm.

Comment 4 Michał Górny archtester

2013-10-09 17:14:21 UTC

Well, committed it anyway. Please reopen if the bug persists.

Comment 5 Davide Pesavento (RETIRED) gentoo-dev

2013-10-14 16:54:39 UTC

(In reply to Michał Górny from comment #3)

Works perfectly here too, thanks!