Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 48622

Summary: vimspell only highlights mispelled words in Subject: line for emails
Product: Gentoo Linux Reporter: Greg Kroah-Hartman (RETIRED) <gregkh>
Component: Current packagesAssignee: Vim Maintainers <vim>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-04-21 15:35:30 UTC
With the latest vim version, vimspell now only highlights the misspelled words
on the Subject: line within an email, instead of all of the body of the email
too.

Latest version of vimspell also has this problem.

Reproducible: Always
Steps to Reproduce:
1. Write email in vim with badly spelled words
2. start spellcheck (\ss)
3. Notice that nothing is highlighted
Comment 1 Ciaran McCreesh 2004-04-21 18:56:47 UTC
Can reproduce with gvim 6.2-r8 (patches up to 6.2.461), vimspell 1.83 and aspell 0.50.3. The same setup with vimspell 1.78 works correctly. Contacting upstream with this, as it's tricky to track down where the break was introduced without seperate diffs for all the changes made.
Comment 2 Ciaran McCreesh 2004-04-21 19:07:29 UTC
Date: Thu, 22 Apr 2004 03:05:02 +0100
From: Ciaran McCreesh <ciaranm AT gentoo DOT org>
To: mathieu DOT clabaut AT free DOT fr
Subject: vimspell 1.83 + email breakage

Hi,

Vimspell 1.83 seems to have problems handling emails. It no longer
highlights any mistakes made inside the body of the email, only those in
the Subject: line. Version 1.78 appears to work correctly.

There's a full report in Gentoo's bugzilla:

http://bugs.gentoo.org/show_bug.cgi?id=48622

If you need any more information, please feel free to ask. I can provide
a full test case with example data if necessary.

Thanks very much,
--
Comment 3 Ciaran McCreesh 2004-04-22 09:13:54 UTC
Looks like it's an intentional change. Reply from upstream:

 Try to add 'mail' to the spell_markup_ft variable. Put in your .vimrc
 the following line :
   let spell_markup_ft = ",html,php,xhtml,dtml,tex,mail,"

 It will be the default value in the next release.

 The logic of highlighting as change in the last versions, in order to
 improve speed, which explains the problem.

I've added 1.84 to CVS which includes mail in the defaults. Assuming cvs->rsync and distfiles->mirrors are working, it should show up within a few hours. This fixes things for me -- could you please confirm?
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-04-23 09:50:52 UTC
Fixed in the latest release, thanks a lot.