Summary: | www-client/firefox-24.0 USE=pgo -debug - make[1]: *** No rule to make target `pgo-profile-run'. Stop. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Richard Grenville <pyxlcy> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | bircoph |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
firefox-24.0-r1 build log showing the failure
mozconfig-3-pgo-fix.patch (Fixes PGO building, to be applied on mozconfig-3.eclass) |
Description
Richard Grenville
2013-09-25 08:01:35 UTC
Created attachment 359422 [details]
firefox-24.0-r1 build log showing the failure
Huh, I made a mistake here. `! use pgo` should not used in `mozconfig-3.eclass` as probably not all mozilla ebuilds have the USE flag, and use() dies when it encounters a non-existent flag since EAPI 5. `! use_if_iuse pgo` (eutils.eclass) might be more appropriate. PGO builds are not supported. You had to unmask the flag in order to use. Please provide a patch that actually fixes that problem and not a workaround Created attachment 359580 [details, diff] mozconfig-3-pgo-fix.patch (Fixes PGO building, to be applied on mozconfig-3.eclass) Mozilla has clearly stated that PGO builds require --enable-tests ( https://developer.mozilla.org/en-US/docs/Building_with_Profile-Guided_Optimization ), and your mozconfig-3.eclass is not following the rule. I don't think there are any more appropriate fixes other than patching mozconfig-3.eclass . This patch fixes the missing pgo USE flag issue mentioned in my last comment. I did limited tests with the patch only, with firefox-24.0-r1[pgo,-debug], firefox-24.0-r1[-pgo,-debug], and thunderbird-24.0-r1. They all successfully pass the first phase of `ebuild compile` (Mozilla's configure scripts), and the options are passed correctly. |