Summary: | app-admin/salt should optionally depend on dev-python/git-python | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | W. Trevor King <wking> |
Component: | Current packages | Assignee: | Patrick McLean <chutzpah> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | alunduil, mail, mschiff |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://docs.saltstack.com/ref/file_server/all/salt.fileserver.gitfs.html | ||
Whiteboard: | sed 's/#XXXX/#485522/' after applying the patch | ||
Package list: | Runtime testing required: | --- | |
Attachments: | patch adding `git` USE flag and git-python RDEPEND |
Description
W. Trevor King
2013-09-20 21:45:45 UTC
Created attachment 359154 [details, diff]
patch adding `git` USE flag and git-python RDEPEND
According to the USE flag policy in: http://devmanual.gentoo.org/general-concepts/use-flags/index.html "The usage of a USE flag should not control runtime dependencies when the package does not link to it. Doing so will create extra configuration for the package and re-compilation for no underlying file change on disk. This should be avoided and instead can be conveyed to the user via post install messages if needed." Since this does not create any on-disk changes, there should not be a USE flag. We could add a postinstall message if you like. (In reply to Patrick McLean from comment #2) > According to the USE flag policy in: > http://devmanual.gentoo.org/general-concepts/use-flags/index.html > > "The usage of a USE flag should not control runtime dependencies when the > package does not link to it. Doing so will create extra configuration for > the package and re-compilation for no underlying file change on disk. This > should be avoided and instead can be conveyed to the user via post install > messages if needed." Thanks for the quote, that makes sense. As a counter example, www-apps/ikiwiki has 'extras' and 'minimal' USE flags that control the installation of optional RDEPEND entries (and I'd be very surprised if it's the only such package), so I don't think it's quite that cut and dried. Still, salt should be a high-enough level package that folks won't be too annoyed by manually installing optional runtime dependencies. > Since this does not create any on-disk changes, there should not be a USE > flag. We could add a postinstall message if you like. Works for me. *** Bug 510216 has been marked as a duplicate of this bug. *** |