Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 484418

Summary: dev-python/south: plays with python wrapping internals (unnecessarily)
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Tiziano Müller (RETIRED) <dev-zero>
Status: RESOLVED FIXED    
Severity: QA    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 484398    
Attachments: Patch to the newest ebuild

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-09 21:33:43 UTC
python_compile_all() {
    if use test; then
        django-admin.py-${EPYTHON} startproject southtest \
                       ^^^^^^^^^^^

Please don't play with internals like this. 'django-admin.py' is a wrapper, and eclass sets up environment properly, so the wrapper will choose correct implementation.

And after all, it seems that in your case you want *any* implementation, not something specific.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-14 08:38:51 UTC
Created attachment 358632 [details, diff]
Patch to the newest ebuild

Following changes applied:

1. disabled py3 since it fails tests and no package in-tree requires it.

2. added USE-deps on doc? since otherwise we can't ensure match between jinja and sphinx.

3. fixed python_install_all() to actually install the docs.

4. moved test preparation to python_test() where it fits better.

Please review and lemme know if it's ok to commit. Additionally, please tell me whether similar changes shall be applied to older versions or if you'd prefer removing them.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-17 18:12:08 UTC
Ping.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-13 15:01:27 UTC
+*south-0.8.1-r1 (13 Mar 2014)
+
+  13 Mar 2014; Michał Górny <mgorny@gentoo.org> +south-0.8.1-r1.ebuild,
+  metadata.xml:
+  Clean up and fix the ebuild wrt bug #484418. Switch the maintainership to
+  python@ on previous maintainer's request.