Summary: | multibuild.eclass: please support nested multibuilds | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
Component: | Eclasses | Assignee: | Michał Górny <mgorny> |
Status: | CONFIRMED --- | ||
Severity: | enhancement | CC: | kensington, sam, sci |
Priority: | Low | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://comments.gmane.org/gmane.linux.gentoo.devel/92777 | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=511198 https://bugs.gentoo.org/show_bug.cgi?id=519094 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 530154 |
Description
Christoph Junghans (RETIRED)
2013-09-05 15:50:11 UTC
Well, I see two paths from here but I don't think we should take both. So either: a) make use of multibuild.eclass transparent in multilib-build and distutils-r1. Both eclass would restore MULTIBUILD_VARIANT{,S} inside the loop so that they wouldn't interfere with the ebuild. This would fix the issue but still support only one multibuild in an ebuild. Also some people may get confused when multibuild 'disappears' like this. b) support explicit stacking of MULTIBUILD_VARIANT. ${MULTIBUILD_VARIANT} == ${MULTIBUILD_VARIANT[0]} will have the deepest multibuild (like it has one), and ${MULTIBUILD_VARIANT[n]} would go up. In case of fftw, ${MULTIBUILD_VARIANT[1]} (or [-1]) could be used to obtain the eclass variant ([0] would be multilib-build). Immediate issue fixed, though having two nested multibuilds will still require extra effort to set MULTIBUILD_VARIANTS locally. There was a patch to add that functionality (see url), but it never got applied. Because nobody bothered to review it. The patch looks fairly straightforward, and in the absence of any other feedback I suggest just committing it. Did you test it with your ebuild? In any case, please do and confirm that it works for you ;). I'm not sure if I'm doing it right or not, but I end up with two identical multilib MULTIBUILD_VARIANTs instead of one multilib and one custom. Could you attach the patch you are using since I don't want to repeat the process of extracting it from gmane? And also your ebuild :). Then we can figure out what it was all about. Extracted from mailing list and commited to the gnome overlay for testing in spice-gtk: https://gitweb.gentoo.org/proj/gnome.git/commit/?id=a6623741bbd2f45976d9445d3c28acf26113f8e5 @eva: How is the testing going? Any problems? |