| Summary: | KPPP patch to dial with callback | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Valery Kartel <droid> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | enhancement | CC: | net-dialup |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
kppp-callback.patch
kppp-callback.patch |
||
Created attachment 29608 [details, diff]
kppp-callback.patch
Did you should submit this upstream so that everyone can use it? Valery? What ? You didn't answered Caleb's question, if this is reported upstream or maybe part of KDE 3.2.2 already, so we could close this bug. For current kde versions it exists as a patch only. I think it would be a part of future kde releases [ http://bugs.kde.org/show_bug.cgi?id=66075 ] ------- Additional Comment #9 From Harri Porten 2004-04-24 20:07 ------- OK. Patch is in. Thanks a lot. Hope you get around trying it out before KDE 3.3 gets released. Had to make 1-2 minor modifications needed because of another patch that went in shortly before. Thanks again. PS: english is not my native lang, so I don't understand what is 'upstream' menas. >PS: english is not my native lang, so I don't understand what is 'upstream' menas.
'Upstream' means the original developers of the software, in this case the KDE developers. They decide which patches go in and which not. We don't have the man power to include patches by request, except a major feature is broken, a security hotfix is needed, etc.
Caleb: The patch is added to KDE 3.3, but I can imagine that quite a few KDE 3.2 users may be interested in this feature. What do you think?
Created attachment 35374 [details, diff]
kppp-callback.patch
This new patch is tested with kdenetwork-3.2.3-r1
---------------------- CUT ----------------------
--- kdenetwork-3.2.3-r1.ebuild.orig 2004-07-14 12:05:12.647703344 +0300
+++ kdenetwork-3.2.3-r1.ebuild 2004-07-14 12:04:56.418170608 +0300
@@ -2,7 +2,7 @@
# Distributed under the terms of the GNU General Public License v2
# $Header:
/var/cvsroot/gentoo-x86/kde-base/kdenetwork/kdenetwork-3.2.3-r1.ebuild,v 1.3
2004/06/28 21:37:40 caleb Exp $
-inherit kde-dist
+inherit kde-dist eutils
DESCRIPTION="KDE network apps: kopete, kppp, kget. kmail and knode are now in
kdepim."
@@ -20,6 +20,7 @@
src_unpack() {
kde_src_unpack
epatch ${FILESDIR}/yahoo-fix-connect-062404.patch
+ epatch ${FILESDIR}/kppp-callback.patch
}
src_compile() {
------------------- CUT ---------------------
PS: in existing kdenetwork-3.2.3-r1.ebuild the line "inherit kde-dist" is wrong
because the existing "yahoo-fix-connect" patch is processed with error
"epatch: command not found".
So this line must looks like "inherit kde-dist eutils".
please use kde 3.3 :) |
This patch adds support for callback (cbcp) pppd option to kppp dialer. Tested on kdenetwork-3.2.1 only. Reproducible: Always Steps to Reproduce: 1. 2. 3. kppp-callback.patch must be placed in '/usr/portage/kde-base/kdenetwork/files' in file '/usr/portage/kde-base/kdenetwork/kdenetwork-3.x.x.ebuild' in section src_unpack add this line: epatch ${FILESDIR}/kppp-callback.patch