Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 483030

Summary: app-crypt/efitools-1.4.2-r1 does not respect CC CFLAGS LDFLAGS
Product: Gentoo Linux Reporter: Nikoli <nikoli>
Component: Current packagesAssignee: No maintainer - Look at if you want to take care of it <maintainer-needed>
Severity: normal CC: esigra
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: patch for build system

Description Nikoli 2013-08-30 15:44:35 UTC
* QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/efi-readvar
 * /usr/bin/efi-updatevar
 * /usr/bin/hash-to-efi-sig-list
 * /usr/bin/cert-to-efi-sig-list
 * /usr/bin/sign-efi-sig-list
 * /usr/bin/sig-list-to-certs
Comment 1 Greg Kroah-Hartman (RETIRED) gentoo-dev 2013-08-30 17:01:52 UTC
I don't see this, the Makefile supports LDFLAGS, how are you overriding them that does not work properly for you?
Comment 2 Nikoli 2013-08-30 18:14:38 UTC
I just added to /etc/portage/make.conf this line:
LDFLAGS="-Wl,--hash-style=gnu ${LDFLAGS}"
Comment 3 Greg Kroah-Hartman (RETIRED) gentoo-dev 2013-08-30 21:21:11 UTC
Odd, I don't see what is broken in the Makefiles that need to be changed to resolve this.  Do you know?
Comment 4 Nikoli 2014-02-13 08:42:15 UTC
Created attachment 370284 [details, diff]
patch for build system
Comment 5 Nikoli 2014-02-13 08:42:29 UTC
Created attachment 370286 [details, diff]
Comment 6 Nikoli 2014-02-13 08:48:54 UTC
Updated ebuild:
respect CC CFLAGS LDFLAGS in cli tools
add missing runtime deps for /usr/bin/efitool-mkusb script # may be script should be optional?
fix homepage
support /etc/portage/patches/ (epatch_user)

Do not know much about building .efi files, most likely using Gentoo CFLAGS and LDFLAGS is not safe for them, so i did not change build system behaviour for .efi related things.

Used this file as example:
Comment 7 Pacho Ramos gentoo-dev 2016-08-19 10:04:27 UTC
this looks fixed in latest version