Bug 482996 – media-libs/giflib use eautoreconf fix library location in Prefix

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Benda Xu 2013-08-30 10:25:39 UTC]

The default dlsearch_path is /usr/lib and /lib, which causes library location problems in Prefix. 

This can be fix by running eautoreconf, where Prefixed libtool.m4 can be pulled in by aclocal.

Please review this patch. I'll go ahead to commit it if there is no objection in a week, as I think it is an obvious solution.

Reproducible: Always

[Comment 1 Benda Xu 2013-08-30 10:26:19 UTC]

Created attachment 357412 [details, diff]
giflib.patch

[Comment 2 SpanKY 2013-09-01 19:10:26 UTC]

(In reply to Benda Xu from comment #0)

if the only difference is the generated libtool, then it sounds like you should be updating elibtoolize instead of using the autoreconf hammer.  it's not like giflib has a custom build of libtool.

[Comment 3 Benda Xu 2013-09-21 14:56:06 UTC]

Created attachment 359178 [details, diff]
giflib-4.1.6-r2.patch

Thanks to Mike's comment, I have looked deeper into the bug. And it turns out to be x library which draws in /usr/lib64. Therefore it can be fixed by passing the include and lib paths explicitly.

Actually the if use X; then ... fi block is not necessary, as --x-includes will be ignored when --disable-x11 is in the argument list.

New patch attached.

[Comment 4 Benda Xu 2013-10-18 06:45:09 UTC]

Hi, as this patch is trivial, I'll commit directly if there is no objection in a week.

[Comment 5 SpanKY 2013-10-19 05:49:31 UTC]

why do we care about 4.1.6 ?  we have 4.2.3 already in the tree.

[Comment 6 Benda Xu 2013-11-01 08:44:55 UTC]

Nice, giflib-4.2.3 seems to have regenerated configure with new autotools. Therefore no problem anymore.

Close as obsolete.

Thanks Mike.