Bug 482946 – dev-libs/loki - C++ library of common design patterns and idioms

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Vladimir Pavljuchenkov (SpiderX) 2013-08-29 17:33:42 UTC]

C++ library of designs, containing flexible implementations of common design patterns and idioms.

loki Homepage: http://loki-lib.sourceforge.net/
Ebuild repo on bitbucket: https://bitbucket.org/SpiderX/ebuilds

Project does not have *full* build system (no configure, just Makefiles).

I would like to be a proxy-maintainer for this ebuild.

Reproducible: Always

[Comment 1 Vladimir Pavljuchenkov (SpiderX) 2013-08-29 17:34:30 UTC]

Created attachment 357356 [details]
ebuild

[Comment 2 Vladimir Pavljuchenkov (SpiderX) 2013-08-29 17:34:45 UTC]

Created attachment 357358 [details]
metadata

[Comment 3 Tom Wijsman (TomWij) (RETIRED) 2013-09-02 18:21:23 UTC]

Please use patches instead of sed where possible. For example, if you remove based on line number you might remove an incorrect line when doing a version bump; also note that sed doesn't cause the die to happen if it doesn't match, so if the flags change the first sed for example would do nothing.

For the rest, at least based on the ebuild and the source code it looks good; after you make the above change I will build and test it and add it to the Portage tree.

[Comment 4 Vladimir Pavljuchenkov (SpiderX) 2013-09-06 10:03:20 UTC]

Created attachment 358022 [details]
patches for ebuild

[Comment 5 Vladimir Pavljuchenkov (SpiderX) 2013-09-06 10:12:44 UTC]

Created attachment 358024 [details]
updated ebuild

Sed calls was replaced by epatch.

I also wonder should this ebuild support multilib?
I mean $(get _libdir) from multilib eclass in src_install section.
Library goes to /usr/lib.

I made a research, and I have seen ebuilds of such types in portage with multilib support and without it, so I am in doubt.

[Comment 6 Maxim Koltsov (RETIRED) 2013-09-06 10:21:47 UTC]

(In reply to SpiderX from comment #5)
> Created attachment 358024 [details]
> updated ebuild
> 
> Sed calls was replaced by epatch.
> 
> I also wonder should this ebuild support multilib?
> I mean $(get _libdir) from multilib eclass in src_install section.
> Library goes to /usr/lib.
> 
> I made a research, and I have seen ebuilds of such types in portage with
> multilib support and without it, so I am in doubt.

You can easily support multilib with 'autotools-multilib' eclass. And since this package is a library, multilib makes sense.

[Comment 7 Vladimir Pavljuchenkov (SpiderX) 2013-09-06 11:48:44 UTC]

Created attachment 358036 [details]
updated ebuild with multilib support

> You can easily support multilib with 'autotools-multilib' eclass. And since this package is a library, multilib makes sense.

I could use this eclass, if this package uses autotools, but unfortunately it does not.
So I have to use multilib eclass.
Ebuild was updated, multilib support added.

Thanks for clarification with multilib.

[Comment 8 Markos Chandras (RETIRED) 2013-10-26 15:10:00 UTC]

(In reply to SpiderX from comment #4)
> Created attachment 358022 [details]
> patches for ebuild

Where did you find this patches? Both of them look undocumented. Please add a description on the top of what each patch does. The debug patch does not look good. You shouldn't override CFLAGS like that. What you should do is probably to add #if/defs in makefiles or code for when debug is enabled. Conditional patching in the ebuilds is a bad thing. Same things for the static thing. I would advice you to contact upstream to solve this problem properly.

http://dev.gentoo.org/~vapier/clean-patches

[Comment 9 Patrice Clement (RETIRED) 2017-07-14 13:46:10 UTC]

Hi Vladimir. Are you still interested in merging this in the main tree? Feel free to reopen if you do. Thanks!