Bug 482448 – dev-db/vsqlite++ - A welldesigned and portable SQLite3 Wrapper for C++

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description H.Habighorst 2013-08-25 19:12:42 UTC]

I've added in #482156 an ebuild for mysql-workbench 6.0.6

vsqlite++ is necessary for mysql-workbench 6.0.6 - can someone please review the ebuild file?

I've got no experience in writing ebuilds - vsqlite++ is a small library, only thing I've patched was the removal of O3 in AM_CXXFLAGS.


Reproducible: Always

[Comment 1 H.Habighorst 2013-08-25 19:13:47 UTC]

Created attachment 357000 [details]
ebuild for vsqlite++-0.3.12

boost dependency: taken out of description / website
sqlite dependancy: necessary, but no definite version (except sqlite3) specified

[Comment 2 Tom Wijsman (TomWij) (RETIRED) 2013-08-25 19:19:38 UTC]

You can remove src_configure, src_compile and src_install since those are exported by the eclass and therefore will be used by default. There is also a || die missing on the sed call.

This package has no maintainer so this bug may go unnoticed for a long time.
Gentoo has a dedicated team[1] for assisting users in maintaining orphaned
packages. If you are interested in maintaining this package, please contact
[e-mail]. 

[1]: http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml

[Comment 3 H.Habighorst 2013-08-25 20:18:19 UTC]

Created attachment 357004 [details]
added suggested changes to previous ebuild

[Comment 4 Hans de Graaff 2013-09-01 07:57:40 UTC]

Your SRC_URI is likely to clash with other packages. It's better to include the package name also using the -> syntax, e.g.:

  SRC_URI="https://github.com/vinzenz/vsqlite--/archive/${PV}.tar.gz -> ${P}.tar.gz"

Also, the BSD-3 LICENSE doesn't exist, but as far as I know this is the default BSD license, so:

  LICENSE="BSD"

It would also be nice to support the static-libs flag and control the building/installation of the .a library that way. Most people don't need the .a version.

sqlite is also needed at runtime, so it should RDEPEND on it.

[Comment 5 H.Habighorst 2013-09-01 11:04:25 UTC]

Created attachment 357556 [details]
added suggested changes to previous ebuild

- added RDEPEND with SQLITE (and DEPEND)
- changed license from BSD-3 to BSD
- added IUSE="static-libs" and src_configure for enabling static libraries
- added SRC_URI change

[Comment 6 Hans de Graaff 2013-10-19 13:30:36 UTC]

I have now added this package to the main gentoo tree.

[Comment 7 zvasylvv 2013-10-19 16:48:13 UTC]

Could anybody please explain why this package should belong to 'dev-db' category instead of 'dev-cpp'?

[Comment 8 Hans de Graaff 2013-10-20 07:54:46 UTC]

(In reply to zvasylvv from comment #7)
> Could anybody please explain why this package should belong to 'dev-db'
> category instead of 'dev-cpp'?

To be honest I did not consider this. I guess that vsqlite++ is more a cpp wrapper than a database implementation so it would probably make more sense in dev-cpp. Then again people might look for it in dev-db. I'm not sure I feel strongly enough about this to pkgmove this.

[Comment 9 Sergey Popov (RETIRED) 2013-10-28 18:13:05 UTC]

(In reply to zvasylvv from comment #7)
> Could anybody please explain why this package should belong to 'dev-db'
> category instead of 'dev-cpp'?

Сounter-question: why not? We have, for example phpmyadmin in dev-db/ rather in www-apps/

So, current category makes sense too.