Summary: | net-libs/webkit-gtk-2.0.4 with media-libs/jpeg-9-r1 - Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:345:47: error: cannot convert 'bool' to 'boolean' for argument '2' to 'int jpeg_read_header(j_decompress_ptr, boolean)' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Markus Goppelt <markus.goppelt> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dirk, dschridde+gentoobugs, griffon26, levertond, slyfox, ssuominen |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://trac.webkit.org/changeset/166490/trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 479818 | ||
Attachments: |
build.zip
Fix use of different boolean types in JPEGImageDecoder (webkit-gtk-2.0.4) Fixes mixed use of booleans in JPEGImageDecoder (webkit-gtk-1.8.3) |
Description
Markus Goppelt
2013-08-19 20:42:36 UTC
Created attachment 356442 [details]
build.zip
Are you using jpeg or jpeg-turbo? What versions? It (webkit-gtk) emerges with jpeg-turbo. jpeg version 9-r1 jpeg-turbo 1.3.0-r2 webkit-gtk-1.10.2-r300 fails with a similar error: Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp: In member function ‘bool WebCore::JPEGImageReader::decode(const WebCore::SharedBuffer&, bool)’: Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:263:47: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘2’ to ‘int jpeg_read_header(j_decompress_ptr, boolean)’ Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:340:60: error: cannot convert ‘bool’ to ‘boolean’ in assignment Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:341:41: error: cannot convert ‘bool’ to ‘boolean’ in assignment Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:342:41: error: cannot convert ‘bool’ to ‘boolean’ in assignment Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp: In function ‘boolean WebCore::fill_input_buffer(j_decompress_ptr)’: Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:493:12: error: cannot convert ‘bool’ to ‘boolean’ in return I use jpeg: # equery list \* | grep jpeg media-libs/jpeg-6b-r11 media-libs/jpeg-9-r1 virtual/jpeg-0-r2 virtual/jpeg-62 Created attachment 360240 [details, diff]
Fix use of different boolean types in JPEGImageDecoder (webkit-gtk-2.0.4)
webkit-gtk is using both the bool built-in type and the boolean type defined by libjpeg. This is fine as long as you don't just pass a value of one where the other type is expected. The patch fixes this problem.
I've compile-tested this with webkit-gtk 2.0.4 and jpeg-9. I expect this to work also with older versions of libjpeg but some testing would be appreciated.
I submitted the following bug report upstream for this issue: https://bugs.webkit.org/show_bug.cgi?id=122412 Created attachment 360242 [details, diff]
Fixes mixed use of booleans in JPEGImageDecoder (webkit-gtk-1.8.3)
1.8.3 suffers from the same problem, but the code was slightly different so I had to make a separate patch.
Got the same breakage here as well. The fix is tiny and looks correct. Upstream bug closed, fix committed: http://trac.webkit.org/changeset/166490 upstream patch... http://trac.webkit.org/changeset/166490/trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp ...applied to both SLOTs, 2.4.4:3 and 2.4.4-r200:2 |