Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 480658

Summary: sys-devel/llvm flawed check-reqs logic
Product: Gentoo Linux Reporter: Julian Ospald <hasufell>
Component: New packagesAssignee: Bernard Cafarelli <voyageur>
Status: RESOLVED WONTFIX    
Severity: normal CC: mgorny, toolchain
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Julian Ospald 2013-08-11 17:53:05 UTC
elif is-flagq -g || is-flagq -ggdb; then

will give false-positives when I have e.g. "-g0" appended and die without purpose
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-11 20:07:22 UTC
Suggested fix?
Comment 2 Julian Ospald 2013-08-11 20:44:18 UTC
we'd probably need regexp support for is-flagq
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-11 20:49:43 UTC
Just to be clear, do you mean that the '-g' check matches '-g0', or you have something like '-g -g0'?
Comment 4 Julian Ospald 2013-08-11 20:50:33 UTC
I mean '-g -g0' or even '-g -some-other-flag -g0', yes
Comment 5 Julian Ospald 2013-08-11 20:51:13 UTC
I think that setup is not uncommon, because it's the easiest way to disable "-g" for a particular package without doing weird bash substitution or redefining the whole CFLAGS.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-11 20:54:54 UTC
Supporting such a thing would probably require something like get-flag-pos or even more scary... and I told that introducing the check-reqs thing is going to be give more trouble than benefit, eh.

@toolchain, anything you could suggest?
Comment 7 SpanKY gentoo-dev 2013-09-30 00:51:23 UTC
(In reply to Michał Górny from comment #6)

we don't have any toolchain-funcs helpers atm that'd handle this

seems like it only comes up when people have -g in their own global make.conf and then additionally set -g0 in per-package env files.  i'd suspect this is uncommon.  to the point where the 5 people who do this and read ewarnings can suffer it ...
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-30 06:51:44 UTC
As vapier said, then.