Summary: | =dev-qt/qtgui-4.8.5 with media-libs/jpeg-9-r1 - In function ‘boolean qt_fill_input_buffer(j_decompress_ptr)’: ../../../gui/image/qjpeghandler.cpp:163:12: error: cannot convert ‘bool’ to ‘boolean’ in return | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Kobboi <gentoo> |
Component: | [OLD] Library | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | achurch+gentoo, hwoarang, levertond, mbays |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 479818 | ||
Attachments: |
build.log
Patch |
Description
Kobboi
2013-08-07 17:30:25 UTC
jpeg-9 is known to be broken, use at least jpeg-9-r1 if you can still reproduce with -r1, reopen the bug and attach complete build.log *** This bug has been marked as a duplicate of bug 479808 *** Created attachment 355466 [details]
build.log
Still there with media-libs/jpeg-9-r1 (never had 9 on my system actually)
Created attachment 355836 [details, diff]
Patch
Another case of breakage due to the jpeg-9 API change.
(In reply to Andrew Church from comment #3) > Created attachment 355836 [details, diff] [details, diff] > Patch > Is this upstream? If not, can you submit it there? could someone submit this? downgrade is unsupported - users like me might loose KDE ive tried an hour to emerge the patch different ways with no luck Andrew, is the patch compatible with older media-libs/jpeg? Have you submitted it upstream? Yes, it is (in theory; I haven't actually tested) compatible with older libjpeg; no, I haven't submitted it upstream. (In reply to Andrew Church from comment #7) > Yes, it is (in theory; I haven't actually tested) compatible with older > libjpeg; no, I haven't submitted it upstream. Ok, can you please submit it to gerrit https://codereview.qt-project.org/ ? I didn't see any obvious way to create a Gerrit account, so I filed https://bugreports.qt-project.org/browse/QTBUG-33166 instead. (In reply to Andrew Church from comment #9) > I didn't see any obvious way to create a Gerrit account, so I filed > https://bugreports.qt-project.org/browse/QTBUG-33166 instead. They don't accept patches attached to jira bug reports. You have to sign the CLA and submit through gerrit. See http://qt-project.org/wiki/Setting-up-Gerrit Sorry, I'm not interested in signing random agreements just to submit a patch. Feel free to submit it yourself if you'd like. I will try to upstream this. This is fixed upstream for 4.8.6 and 5.1.2 https://qt.gitorious.org/qt/qt/commit/2a9ea11f4dea51f9e75036aab8e7a23f0eb4bd1f/diffs *** Bug 492746 has been marked as a duplicate of this bug. *** Any progess on this topic? (In reply to Stolz from comment #15) > Any progess on this topic? (In reply to Michael Palimaka (kensington) from comment #13) > This is fixed upstream for 4.8.6 and 5.1.2 > > https://qt.gitorious.org/qt/qt/commit/ > 2a9ea11f4dea51f9e75036aab8e7a23f0eb4bd1f/diffs (In reply to Michael Palimaka (kensington) from comment #16) > (In reply to Stolz from comment #15) > > Any progess on this topic? > > (In reply to Michael Palimaka (kensington) from comment #13) > > This is fixed upstream for 4.8.6 and 5.1.2 > > > > https://qt.gitorious.org/qt/qt/commit/ > > 2a9ea11f4dea51f9e75036aab8e7a23f0eb4bd1f/diffs I know it's fixed upstream. Also Andrew Church patch works. I just wonder why the only available version of dev-qt/qtgui in Portage is 4.8.5-r1 if the upstream version has fixed this problem. Upstream hasn't yet released a new version. It's not backported into portage due to qt team being seriously understaffed. Fixed in qtgui-4.8.5-r3 04 Jul 2014; Davide Pesavento <pesa@gentoo.org> +files/qtgui-4.8.5-libjpeg-9.patch, qtgui-4.8.5-r3.ebuild: Backport patch to fix build with media-libs/jpeg-9 (bug 480182). |