Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 479838

Summary: java-ant-2: move the Python code to javatoolkit
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: EclassesAssignee: Java team <java>
Status: RESOLVED FIXED    
Severity: normal CC: jlec, python
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=475346
https://bugs.gentoo.org/show_bug.cgi?id=552332
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 482404, 501728    
Bug Blocks: 455102    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-05 14:23:01 UTC
The java-ant_remove-taskdefs() function has a bunch of Python code that implies direct dependency on Python. That's a bad idea and -- unless I'm missing something -- it requires Python with USE=xml. Therefore, the snippet can pretty easily fail with what your dependency can't enforce.

Could you please move it to javatoolkit as a separate tool? This way, javatoolkit would enforce proper Python deps, the wrapper would choose a proper implementation and everything would unconditionally work fine. The eclass adds dependency on javatoolkit anyway, so that wouldn't be a problem.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-12-19 18:57:30 UTC
Ping. Any chance to fix this?
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-12-29 13:23:00 UTC
Ah, another weekly reminder. Looked into the consumers this time, there are only two; do we even want to retain this functionality at all if nobody ever uses it?

It seems that these could just be replaced by build.xml patches for now. Then if we want to do proper build.xml tool based patching later we can implement that in a later generation of the eclass and/or the Java tools.

Java team, ping, any other thoughts? Agree? Disagree? TYIA

For reference:

 $ grep -r java-ant_remove-taskdefs /usr/portage/
/usr/portage/dev-java/jspeex/jspeex-0.9.7.ebuild:
    java-ant_remove-taskdefs --name proguard
/usr/portage/app-misc/freemind/freemind-0.9.0-r1.ebuild:
    java-ant_remove-taskdefs --name jarbundler # macOS only
/usr/portage/eclass/java-ant-2.eclass:
    # java-ant_remove-taskdefs
/usr/portage/eclass/java-ant-2.eclass:
    # @FUNCTION: java-ant_remove-taskdefs
/usr/portage/eclass/java-ant-2.eclass:
    java-ant_remove-taskdefs() {
 $
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-02-15 18:48:47 UTC
Ping. Could we move on, please?
Comment 4 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-02-18 22:45:16 UTC
+  18 Feb 2014; Tom Wijsman <TomWij@gentoo.org>
+  +files/jspeex-0.9.7-remove-proguard-taskdef.patch, +jspeex-0.9.7-r1.ebuild,
+  -jspeex-0.9.7.ebuild, files/jspeex-0.9.7-remove-junit-report.patch:
+  Replace java-ant_remove-taskdefs by a patch, see bug #479838.

+  18 Feb 2014; Tom Wijsman <TomWij@gentoo.org> +freemind-1.0.0-r1.ebuild,
+  -freemind-1.0.0.ebuild:
+  Remove java-ant_remove-taskdefs as the taskdef is no longer present, see bug
+  #479838.

This last one needs stabilization in order to proceed, will block this bug.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-31 15:27:36 UTC
*** Bug 475346 has been marked as a duplicate of this bug. ***
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2014-03-31 15:33:11 UTC
Please move. On a ~arch system using default PYTHON_TARGETS python:3.4 gets pulled in. (I know, that's not dramatic, but inconvenient)
Comment 7 Johann Schmitz (ercpe) (RETIRED) gentoo-dev 2014-03-31 16:30:54 UTC
(In reply to Tom Wijsman (TomWij) from comment #4)
> +  18 Feb 2014; Tom Wijsman <TomWij@gentoo.org> +freemind-1.0.0-r1.ebuild,
> +  -freemind-1.0.0.ebuild:
> +  Remove java-ant_remove-taskdefs as the taskdef is no longer present, see
> bug
> +  #479838.
> 
> This last one needs stabilization in order to proceed, will block this bug.

app-misc/freemind/freemind-0.9.0-r1 seems to be the only remaining consumer of the function. Once 1.0.0-r1 is stable on ppc and x86 (see blocking bug) we can drop it.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-31 16:50:31 UTC
+  31 Mar 2014; Michał Górny <mgorny@gentoo.org> freemind-0.9.0-r1.ebuild:
+  Move the java-ant_remove-taskdefs function from the ebuild since this ebuild
+  is the last consumer of it. This is least-change way of fixing the eclass.

+  31 Mar 2014; Michał Górny <mgorny@gentoo.org> java-ant-2.eclass:
+  Ban the java-ant_remove-taskdefs() function and remove Python dependency, bug
+  #479838.

Hope you don't mind, this should make us much happier now.