Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 478442

Summary: gnome-extra/evolution-data-server-3.8.4 - invalid implementation in PYTHON_COMPAT: python3
Product: Gentoo Linux Reporter: iGentoo <AlphatPC>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: cslycord, python
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=480326
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 463242    
Attachments: evolution-data-server-3.8.4.ebuild.diff

Description iGentoo 2013-07-28 08:06:48 UTC
Created attachment 354386 [details, diff]
evolution-data-server-3.8.4.ebuild.diff

gnome-extra/evolution-data-server/evolution-data-server-3.8.4.ebuild:
  4 
  5 EAPI="5"
  6 GCONF_DEBUG="no"
  7 PYTHON_COMPAT=( python{2_7,3,3} )
  8 VALA_MIN_API_VERSION="0.18"
  9 VALA_USE_DEPEND="vapigen"
 10 


# echo python{2_7,3,3}
python2_7 python3 python3
...
Comment 1 Julian Ospald 2013-07-28 08:31:29 UTC
@python herd ...can we get checks for this? Maybe both repoman and eclass error. It only seems fatal for this ebuild if python:2.7 is not installed.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-07-28 08:41:26 UTC
(In reply to Julian Ospald (hasufell) from comment #1)
> @python herd ...can we get checks for this? Maybe both repoman and eclass
> error. It only seems fatal for this ebuild if python:2.7 is not installed.

Well, the main reason for lack of this check is that we're iterating over 'all implementation' list rather than PYTHON_COMPAT, so it's filtered silently.

I see two possibilities:

1. add additional sanity check with PYTHON_COMPAT iteration,

2. iterate over PYTHON_COMPAT and respect the order in which impls are provided there.

(2) is a behavior change and I'm not really convinced if it's wanted. Most people list implementations like 'python2* python3* ...' which means that python3 would be preferred when it's not :). On the other hand, this will allow us to make pypy ebuilds actually prefer pypy like upstream suggests.

(1) should be simple enough to implement without thinking.
Comment 3 Pacho Ramos gentoo-dev 2013-07-28 10:19:26 UTC
+  28 Jul 2013; Pacho Ramos <pacho@gentoo.org>
+  evolution-data-server-3.8.4.ebuild:
+  Fix PYTHON_COMPAT (#478442 by Alphat-PC)
+
Comment 4 iGentoo 2013-07-28 15:01:57 UTC
(In reply to Pacho Ramos from comment #3)
> +  28 Jul 2013; Pacho Ramos <pacho@gentoo.org>
> +  evolution-data-server-3.8.4.ebuild:
> +  Fix PYTHON_COMPAT (#478442 by Alphat-PC)
> +

# unpack evolution-data-server-3.8.4.tar.xz
# cd evolution-data-server-3.8.4/addressbook/libebook-contacts
# python3 ./gen-western-table.py < e-name-western-tables.h.in 
  File "./gen-western-table.py", line 26
    print "static const gchar %s_table[] = {" % var
                                            ^
SyntaxError: invalid syntax
Comment 5 Pacho Ramos gentoo-dev 2013-07-28 15:16:45 UTC
https://bugzilla.gnome.org/show_bug.cgi?id=705028
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-07-30 16:23:59 UTC
*** Bug 478782 has been marked as a duplicate of this bug. ***