Summary: | New ebuild: xmame | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Per Wigren <tuxie> |
Component: | New packages | Assignee: | Ryan Phillips (RETIRED) <rphillips> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | 1.0 RC6 r14 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Per Wigren
2002-02-01 13:49:41 UTC
Please set: defaultgame robby in xmamerc instead of pacman, because robby is in xmame-extras (public domain rom) *shrug* Regards Per Wigren Jeez, I really shouldn't submit things when I'm as tired as I was... 1. s/ARGS/SOUND/g in src_compile() 2. MANDIR= statement not needed on the make-line 3. the xmamerc should of course be /usr/lib/xmame/xmamerc 4. remove all "<NULL> (not set)" lines in xmamerc.. Should I make a new ebuild and submit it? Hi! There already exists an ebuild for xmame in app-games/xmame However, the package version does need to be upgraded. If you don't mind, why don't you look at the latest existing ebuild (0.56.1) and adapt that to 0.57.1 Unfortunately, your submitted ebuild is not polished enough (IMHO) as is to commit to portage. Please take this as *constructive* criticism. Your contributions are appreciated. Note: There exists a bug ( http://bugs.gentoo.org/show_bug.cgi?id=421 ) for moving xmame to app-emulation. I will probably make that move this weekend sometime. If you have any questions, feel free to email me directly. tod@gentoo.org ok, my bad. I only looked in app-emulation... :P I looked at the 0.56.1.ebuild and found a bug: It does a "dosym xmame.SDL /usr/bin/xmame" at the end, but if I don't have "USE sdl" defined, it will be called "xmame.x11" ... It also should be "chown root:games" + "chmod 4710" to make a "secure suid root" so we can use DGA.. You may also consider to include a xmamerc so it finds the samples, artwork etc in xmame-extras which I still consider good. |