Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 477824

Summary: app-emulation/xen-tools-4.3.0 installs non-POSIX init scripts
Product: Gentoo Linux Reporter: Julian Ospald <hasufell>
Component: New packagesAssignee: Gentoo Xen Devs <xen>
Status: RESOLVED TEST-REQUEST    
Severity: QA CC: idella4
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 478236    

Description Julian Ospald 2013-07-22 23:19:10 UTC
* QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/xendomains line 16 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -z ${name_from_file} ]] ; then
 *    possible bashism in /etc/init.d/xendomains line 28 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	[[ "${SCREEN}" == "yes" || "${SCREEN}" == "YES" ]]	
 *    possible bashism in /etc/init.d/xendomains line 28 (should be 'b = a'):
 *    	[[ "${SCREEN}" == "yes" || "${SCREEN}" == "YES" ]]	
 *    possible bashism in /etc/init.d/xendomains line 49 (alternative test command ([[ foo ]] should be [ foo ])):
 *    		if [[ $? -ne 0 ]] ; then
 *    possible bashism in /etc/init.d/xendomains line 80 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ "$PARALLEL_SHUTDOWN" = "yes" ]] ; then
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2013-07-23 05:39:19 UTC
  23 Jul 2013; Ian Delaney <idella4@gentoo.org> files/xendomains.initd-r1,
  files/xendomains.initd-r2:
  Correct xendomains.init(s) to POSIX compliant, fixes Bug #477824
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2013-07-27 06:12:54 UTC
Reset to; [ "${SCREEN}" = "yes" -o "${SCREEN}" = "YES" ]

  27 Jul 2013; Ian Delaney <idella4@gentoo.org> files/xendomains.initd-r1,
  files/xendomains.initd-r2:
  Correction to xendomains.initd scripts wrt Bug #477824
Comment 3 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-07-27 10:45:33 UTC
[despite of I'm not in arch-teams] I tested fix from #2 and it works fine now.