Summary: | bash-completion-r1.eclass: fails to install: newins failed 'You should not use ${EPREFIX} with helpers' | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Andrew Udvare <audvare> |
Component: | Prefix Support | Assignee: | Samuli Suominen (RETIRED) <ssuominen> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander, mgorny, mitaspiotr, prefix |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build log |
Description
Andrew Udvare
2013-07-22 05:20:04 UTC
Created attachment 353824 [details]
build log
*** Bug 477694 has been marked as a duplicate of this bug. *** *** Bug 477696 has been marked as a duplicate of this bug. *** *** Bug 477698 has been marked as a duplicate of this bug. *** @Samuli, I think you'll need to strip it off pkg-config. Also, you've introduced *a lot* of indentation errors and random spaces, please fix that. (In reply to Michał Górny from comment #5) > @Samuli, I think you'll need to strip it off pkg-config. My bad, I don't have a prefix installation available :-/ + 22 Jul 2013; Samuli Suominen <ssuominen@gentoo.org> + bash-completion-r1.eclass: + Remove use of EPREFIX wrt #477692 to avoid collision with Portage helpers > Also, you've introduced *a lot* of indentation errors and random spaces, > please fix that. I found some. I hope I got everything you meant. You've broken it more. get_*() were fine. It's pkg-config returning paths with EPREFIX embedded. You need to strip them to return proper paths from _*() helpers. Otherwise they can't be used with dobashcomp() and friends. (In reply to Michał Górny from comment #7) > You've broken it more. get_*() were fine. > > It's pkg-config returning paths with EPREFIX embedded. You need to strip > them to return proper paths from _*() helpers. Otherwise they can't be used > with dobashcomp() and friends. Thanks for looking into it, I had that suspicion about the above. Since this breaks a load of packages, do you mind if I revert Samuli's fix and just do what you said above? (In reply to Fabian Groffen from comment #8) > (In reply to Michał Górny from comment #7) > > You've broken it more. get_*() were fine. > > > > It's pkg-config returning paths with EPREFIX embedded. You need to strip > > them to return proper paths from _*() helpers. Otherwise they can't be used > > with dobashcomp() and friends. > > Thanks for looking into it, I had that suspicion about the above. Since > this breaks a load of packages, do you mind if I revert Samuli's fix and > just do what you said above? Feel free to. Ok, committed in 1.8 Please fix eclass. All completions gets installed in / now. :( - echo "${pcdb#${EPREFIX}}" + echo "${pcbc#${EPREFIX}}" Thanks. I've changed it to 'path' to avoid typos in the future. *** Bug 477892 has been marked as a duplicate of this bug. *** |